260754 - Extension/Theme does not enable by default after installing the updated package

Status: RESOLVED WORKSFORME

(Toolkit :: Add-ons Manager, defect)

Description

[Frank Fridlund]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040913 Firefox/0.10
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040913 Firefox/0.10

Installing Firefox 1.0PR on a system that has 0.9 disables all extensions and
themes not yet compatible to 1.0PR.  When an extension/theme is finally found
and downloaded through the extension system, the extension/theme remains
disabled by default.  It should offer the user in the "Finished installation"
box whether the extension should be enabled (with a default checked), or it
should enable it by default.  The former is the preferred way.  The same can be
said for Thunderbird 0.8.

Reproducible: Always
Steps to Reproduce:

Comment 1

[Jesse Ruderman]

I ran into this bug too.  IMO, an extension should only be disabled after it is
upgraded if the user disabled the extension manually.

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

Have to trim, sadly. A workaround (albeit obscure) exists - one which extension
users may be able to figure out. 

Comment 3

[Robert Strong (they/them - no direct email)]

The latter desired behavior as described in Comment #0 is the current behavior
in that the extension will be enabled by default. Also, the patch in bug 264750
will change the behavior as follows:
a) If an extension is disabled due to it being incompatible and it is updated or
upgraded it will only be enabled if it was not disabled by the user prior to
being disabled due to being incompatible.
b) If an extension is upgraded and it was disabled by the user prior to the
upgrade it will continue to be disabled.

Basically, the user initiated disable will be separated from the app initiated
disable. Once the extension is compatible as far as the app is concerned then
the user initiated disabled state is respected.

Comment 4

[Robert Strong (they/them - no direct email)]

With the checkin of bug 264750 the behavior is more sane. If updated
compatibility info is found for an extension that is disabled because it is
incompatible it will automatically be enabled if the user did not manually
disable it prior to it being disabled because it was incompatible.

Resolving WFM