260861 - Thunderbird Extensions manager: "Install" should be "Install..." (an ellipsis is missing)

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Prognathous]

This button opens the file dialog to browse for XPI files. Browse buttons should
always have an ellipsis.

Tested with today's trunk (version 0.8/20040921))

Prog.

Comment 1

[Mike Cowperthwaite]

Same for the button on the Themes manager.

The Tools|Extensions and Tools|Themes menu items should be "Extensions..." and 
"Themes..." as well.

Comment 2

[Magnus Melin [:mkmelin]]

The extension manager have been redesigned in bug 329045, the only issue now should be the Install button.

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Comment 4

[Robert Strong (they/them - no direct email)]

Comment on attachment 223443 [details] [diff] [review]
proposed fix

>Index: toolkit/locales/en-US/chrome/mozapps/extensions/extensions.dtd
>===================================================================
>RCS file: /cvsroot/mozilla/toolkit/locales/en-US/chrome/mozapps/extensions/extensions.dtd,v
>retrieving revision 1.13
>diff -u -r1.13 extensions.dtd
>--- toolkit/locales/en-US/chrome/mozapps/extensions/extensions.dtd	27 Apr 2006 03:04:32 -0000	1.13
>+++ toolkit/locales/en-US/chrome/mozapps/extensions/extensions.dtd	26 May 2006 15:47:01 -0000
>@@ -21,7 +21,7 @@
> <!ENTITY cmd.checkUpdatesAll.accesskey    "F">
> <!ENTITY cmd.checkUpdatesAllAddon.tooltip "Finds Updates to your Add-ons">
> <!ENTITY cmd.checkUpdatesAllTheme.tooltip "Finds Updates to your Themes">
>-<!ENTITY cmd.installFile.label            "Install">
>+<!ENTITY cmd.installFile.label            "Install...">
> <!ENTITY cmd.installFile.accesskey        "I">
> <!ENTITY cmd.installFileAddon.tooltip     "Install an Add-on">
> <!ENTITY cmd.installFileTheme.tooltip     "Install a Theme">
The name used also needs to be changed so localizers can find the change. You can either change it in this bug or wait for bug 308916 to fix this.

Comment 5

[Magnus Melin [:mkmelin]]

(In reply to comment #4)
> The name used also needs to be changed so localizers can find the change. You
> can either change it in this bug or wait for bug 308916 to fix this.

Robert: the name did not exist in 1.5 versions... (changed/added since then) Still any reason to change it?

Comment 6

[Robert Strong (they/them - no direct email)]

Yes, this way localizers that have localized it already will see the change.

Comment 7

[Robert Strong (they/them - no direct email)]

beltzner, besides this button which displays the file selection dialog and does not have a ... after the text Install there is also the Add-ons and Downloads menu items that don't have a ... after them. What do you think?

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

"..." is appended to commands that present dialogs to get more input required to complete the task. So it makes sense for "Install" to have one, since it requires the user to specify the XPI file to install.

The Add-ons and Downloads menu items aren't commands, they're names of tools which the user can launch from the Tools menu. (Technically speaking, these should be in a "Window" menu or something, since really what the command is doing is "Show Add-ons Manager" and "Show Downloads Manager")

Comment 9

[Robert Strong (they/them - no direct email)]

Ok... I just find Organize Bookmarks... and Options... as not too dissimilar to Downloads and Add-ons Manager.

Comment 10

[Mike Cowperthwaite]

(In reply to comment #8)
> The Add-ons and Downloads menu items aren't commands, they're names of tools
> which the user can launch from the Tools menu. (Technically speaking, these
> should be in a "Window" menu or something, since really what the command is
> doing is "Show Add-ons Manager" and "Show Downloads Manager")

OK; but then for consistency, "Message Filters" shouldn't have an ellipsis either, as the window it opens is also a top-level, standalone, non-blocking window.

Comment 11

[Robert Strong (they/them - no direct email)]

Attachment: patch

Benjamin, just a simple string fix

Comment 12

[(not reading, please use [e-mail] instead)]

Comment on attachment 227209 [details] [diff] [review]
patch

r=sspitzer

Comment 13

[Robert Strong (they/them - no direct email)]

Checked in to trunk

Comment 14

[Robert Strong (they/them - no direct email)]

Comment on attachment 227209 [details] [diff] [review]
patch

Requesting 1.8.1 for this simple string fix

Comment 15

[Robert Strong (they/them - no direct email)]

checked in to MOZILLA_1_8_BRANCH

Comment 16

[Carsten Book [:Tomcat]]

verified fixed 1.8.1.3 using Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.3) Gecko/20070326 Thunderbird/2.0.0.0 Mnenhy/0.7.5.0 ID:2007032620