update download manager shortcut everywhere; IE has no View Source shortcut; Web Search is Ctrl+E in IE

RESOLVED FIXED

Status

RESOLVED FIXED
14 years ago
3 years ago

People

(Reporter: steffen.wilberg, Assigned: steffen.wilberg)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

5.37 KB, patch
jwalden+fxhelp
: review+
Details | Diff | Splinter Review
(Assignee)

Description

14 years ago
 
(Assignee)

Comment 1

14 years ago
Created attachment 159633 [details] [diff] [review]
patch

damn shortcuts.
(Assignee)

Comment 2

14 years ago
Created attachment 159634 [details] [diff] [review]
correct patch

forgot a tag.

Note that IE's Ctrl+E shortcut is the reason we're using it on Windows as well
for Web Search. And IE doesn't have a Page Source shortcut.
Attachment #159633 - Attachment is obsolete: true
(Assignee)

Comment 3

14 years ago
Comment on attachment 159634 [details] [diff] [review]
correct patch

Simple changes, but error prone.
Attachment #159634 - Flags: review?(jwalden+fxhelp)
Comment on attachment 159634 [details] [diff] [review]
correct patch

>+    or by pressing <span class="noUnix"><kbd>Ctrl</kbd>+<kbd>J</kbd></span>
>+    <span class="unix"><kbd>Ctrl</kbd>+<kbd>Y</kbd></span>) stores shortcuts to
>+    your recent downloads. The Download options are available in the

As it is, on non-Unix platforms there will be a space between the J of Ctrl+J
and the parenthesis due to the whitespace between the <span class="noUnix"/>
and the <span class="unix"/> elements.	Remove the space by fiddling with the
alignment of stuff, make sure no spaces show on any platform however you do it,
and r=me.
Attachment #159634 - Flags: review?(jwalden+fxhelp) → review+
Oh -- I've synced the docs in branch and trunk, so please check it into both.

Right now, Help should be completely synced on branch and trunk except for Help
viewer changes -- they've been reviewed and approved for aviary, so do you know
if they'd be okay to check into trunk as well?
(Assignee)

Comment 6

14 years ago
Yeah, I've seen your trunk checkin.
Checked in br & trunk, with comment addressed.

You can check anything into the trunk as soon as it is reviewed. Approval is not
needed there. I'd even recommend to try Help viewer changes in the trunk before
taking them to the branch. But hurry up, the trunk is scheduled to freeze for
1.8a4 on 22-Sep 11:59 P.M.

But which Help viewer changes do you mean?
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.