260900 - Memory leak happens when mozilla runs.

Status: VERIFIED INVALID

(Core :: XPConnect, defect)

Description

[Andrew Tong]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040917
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040917

I have used valgrind2.2.0 to detect memory leaks in mozilla and found this problem.

Reproducible: Always
Steps to Reproduce:
1.run mozilla under valgrind2.2.0, while set "--tool=memcheck" in valgrind.
2.read the report supplied by valgrind.
3.run mozilla under gdb.

Actual Results:  
memory leak

Comment 1

[Boris Zbarsky [:bzbarsky]]

So what leaks, exactly?

Comment 2

[David Bradley]

And keep in mind there are a number of one time leaks that due to our current
shutdown situation can't be addressed.

Comment 3

[Andrew Tong]

Attachment: free the memory

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

per http://www.mozilla.org/js/spidermonkey/apidoc/gen/api-JS_GetStringBytes.html
the result of JS_GetStringBytes should not be free'd. this patch seems to be wrong.

Comment 5

[Brendan Eich [:brendan]]

The patch is invalid, as biesi said.  The bug as written is invalid, too -- no
evidence, no acknowledgement of tool pointer-tracing limitations, and no
acknowledgement of existing bugs on shutdown leaks.

/be

Comment 6

[Andrew Tong]

Comment on attachment 160216 [details] [diff] [review]
free the memory

Can you review this patch, please?

Comment 7

[Mike Shaver (:shaver emeritus)]

Comment on attachment 160216 [details] [diff] [review]
free the memory

Sorry, no.  Please see biesi and brendan's comments.

(I guess I _am_ reviewing this patch, though.)