260924 - MessengerSetDefaultCharacterSet should be named MessengerSetForcedCharacterSet

Status: RESOLVED FIXED

(MailNews Core :: Internationalization, defect)

Description

[Eyal Rozenberg]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a3) Gecko/20040817
Build Identifier: 

MessengerSetDefaultCharacterSet in mailnews/base/resources/content/shareglue.js
does not set the default character set, it sets - overrides, rather - the
character set of the current message. The corresponding browser function is 
SetForcedCharset() , so I suggest this be named MessengerSetForcedCharacterSet()
 (or MessengerSetForcedCharset() if you like, but that would break the principle
of minimum changes).

Reproducible: Always
Steps to Reproduce:

Comment 1

[Eyal Rozenberg]

Attachment: name change patch v1

Patch making the suggested name change. The name should also be changed in

/toolkit/content/charsetOverlay.js, line 32
/toolkit/content/charsetOverlay.js, line 36

but my source tree doesn't seem to have a toolkit/ subdir.

Comment 2

[Eyal Rozenberg]

Attachment: name change v2

Now with /toolkit/ name change.

Comment 3

[Simon Montagu :smontagu]

Patch checked in.

Comment 4

[Ian Neal]

Relanded after aviary branch landing