260931 - Common Dialog's checkbox does not wrap

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[[e-mail]]

The longest example I noticed of a checkbox in a common dialog prompt is the
mixed content show again label, "Alert me whenever I'm about to view an
encrypted page that contains some unencrypted information." This label is so
long that it needs to wrap to the 45em max-width set on the ancestor vbox. It
currently does not because it has been made inflexible to allow it to display
nicer focus ring and hover styles. Fortunately I have discovered a way to allow
it to flex without forcing it to flex.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[[e-mail]]

Comment on attachment 159714 [details] [diff] [review]
Proposed patch

Whoops, this breaks prompt() - need to think some more about this :-(

Comment 3

[[e-mail]]

Attachment: Better patch

OK, so this fixes it because the hbox doesn't enforce a width on the checkbox,
expecting it to flex if it wants more (or less) width, while the vbox does
enforce the checkbox max width; the align="start" allows the checkbox to
shrink.

Comment 4

[jag (Peter Annema)]

Comment on attachment 159715 [details] [diff] [review]
Better patch

sr=jag

Comment 5

[[e-mail]]

Fix checked in.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: toolkit port (checked in)

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 169062 [details] [diff] [review]
toolkit port (checked in)

Checking in toolkit/content/commonDialog.xul;
/cvsroot/mozilla/toolkit/content/commonDialog.xul,v  <--  commonDialog.xul
new revision: 1.5; previous revision: 1.4
done