Closed
Bug 261090
Opened 20 years ago
Closed 20 years ago
pkg-config --libs can add things like -Wl,--export-dynamic to our command line
Categories
(SeaMonkey :: Build Config, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.8alpha5
People
(Reporter: dbaron, Assigned: dbaron)
References
Details
(Whiteboard: [patch])
Attachments
(1 file)
1.40 KB,
patch
|
bryner
:
review+
darin.moz
:
superreview+
asa
:
approval-aviary+
asa
:
approval1.7.5+
|
Details | Diff | Splinter Review |
On my Fedora Core 2 system:
$ pkg-config --libs gtk+-2.0
-Wl,--export-dynamic -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgdk_pixbuf-2.0 -lm
-lpangoxft-1.0 -lpangox-1.0 -lpango-1.0 -lgobject-2.0 -lgmodule-2.0 -ldl -lglib-2.0
-Wl,--export-dynamic makes our libraries much larger. I think we should use
--libs-only-L and --libs-only-l to avoid picking up options like this.
This bug was causing my libgklayout.so to be 911,936 bytes larger than it needed
to be by inflating the dynamic symbol table. (same difference stripped or
not-stripped)
Assignee | ||
Comment 1•20 years ago
|
||
Assignee | ||
Comment 2•20 years ago
|
||
*** Bug 261089 has been marked as a duplicate of this bug. ***
Assignee | ||
Updated•20 years ago
|
Attachment #159795 -
Flags: superreview?(darin)
Attachment #159795 -
Flags: review?(bryner)
Assignee | ||
Updated•20 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [patch]
Target Milestone: --- → mozilla1.8alpha4
Updated•20 years ago
|
Attachment #159795 -
Flags: superreview?(darin) → superreview+
Updated•20 years ago
|
Attachment #159795 -
Flags: review?(bryner) → review+
Assignee | ||
Comment 3•20 years ago
|
||
Fix checked in to trunk, 2004-09-29 22:19/23 -0700.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.8alpha4 → mozilla1.8alpha5
Comment 4•20 years ago
|
||
Would this be appropiate to also have for firefox 1.0. seems to me this would
result in a smaller gtk2 build
Flags: blocking-aviary1.0?
Assignee | ||
Comment 5•20 years ago
|
||
I think our official builds are built on older systems that don't have this problem.
Comment 6•20 years ago
|
||
Comment on attachment 159795 [details] [diff] [review]
patch
I'd like to get this on the branches for the linux distributors, unless there
were problems with this I'm not aware of.
Attachment #159795 -
Flags: approval1.7.x?
Attachment #159795 -
Flags: approval-aviary?
Updated•20 years ago
|
Flags: blocking-aviary1.0? → blocking-aviary1.0-
Comment 7•20 years ago
|
||
Comment on attachment 159795 [details] [diff] [review]
patch
a=asa for aviary and 1.7x checkin.
Attachment #159795 -
Flags: approval1.7.x?
Attachment #159795 -
Flags: approval1.7.x+
Attachment #159795 -
Flags: approval-aviary?
Attachment #159795 -
Flags: approval-aviary+
Comment 8•20 years ago
|
||
(In reply to comment #6)
> (From update of attachment 159795 [details] [diff] [review])
> I'd like to get this on the branches for the linux distributors, unless there
> were problems with this I'm not aware of.
The Fedora trio (Seamonkey, Firefox, and Thunderbird) of RPMs have shipped this
patch for over a month. Seems fine. Ship it.
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•