261090 - pkg-config --libs can add things like -Wl,--export-dynamic to our command line

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect, P1)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

On my Fedora Core 2 system:
 $ pkg-config --libs gtk+-2.0
-Wl,--export-dynamic -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgdk_pixbuf-2.0 -lm
-lpangoxft-1.0 -lpangox-1.0 -lpango-1.0 -lgobject-2.0 -lgmodule-2.0 -ldl -lglib-2.0

-Wl,--export-dynamic makes our libraries much larger.  I think we should use
--libs-only-L and --libs-only-l to avoid picking up options like this.

This bug was causing my libgklayout.so to be 911,936 bytes larger than it needed
to be by inflating the dynamic symbol table.  (same difference stripped or
not-stripped)

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

*** Bug 261089 has been marked as a duplicate of this bug. ***

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2004-09-29 22:19/23 -0700.

Comment 4

[Yusuf Goolamabbas]

Would this be appropiate to also have for firefox 1.0. seems to me this would
result in a smaller gtk2 build

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I think our official builds are built on older systems that don't have this problem.

Comment 6

[Benjamin Smedberg]

Comment on attachment 159795 [details] [diff] [review]
patch

I'd like to get this on the branches for the linux distributors, unless there
were problems with this I'm not aware of.

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 159795 [details] [diff] [review]
patch

a=asa for aviary and 1.7x checkin.

Comment 8

[Christopher Aillon (sabbatical, not receiving bugmail)]

(In reply to comment #6)
> (From update of attachment 159795 [details] [diff] [review])
> I'd like to get this on the branches for the linux distributors, unless there
> were problems with this I'm not aware of.


The Fedora trio (Seamonkey, Firefox, and Thunderbird) of RPMs have shipped this
patch for over a month.  Seems fine.  Ship it.