261385 - Inconsistent selection schemes in HTML tables

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

1. launch Composer
2. create a 3x3 table, the first line being only TH elements
3. put some text in each cell
4. place the caret in a TH on first line and extend the selection

   ==> this selects the text in the cells

5. now place the caret in a TD and extend the selection

   ==> this selects cells

This is not intentional and it is a bug. In particular, if you copy a textual
selection created by step 4 and paste it elsewhere in the document, you may end
up with very funky incomplete tables...

Comment 1

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: fix #1

we never really cared about table header cells...

Comment 2

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 159963 [details] [diff] [review]
fix #1

Neil can you review please ?

Comment 3

[[e-mail]]

Comment on attachment 159963 [details] [diff] [review]
fix #1

>-  return (aContent->Tag() == nsHTMLAtoms::td &&
>+  return ((aContent->Tag() == nsHTMLAtoms::td ||
>+           aContent->Tag() == nsHTMLAtoms::th) &&
>           aContent->IsContentOfType(nsIContent::eHTML));
Nit: probably cheaper to do the content type test first.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Daniel: is this ready to go?

Comment 5

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 159963 [details] [diff] [review]
fix #1

roc, can you sr this trivial patch please ? Thanks!

Comment 6

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

checked in