26149 - AutoFill Password dialog won't go away upon cancelling

Status: VERIFIED FIXED

(Core :: Networking, defect, P3)

Description

[sairuh (rarely reading bugmail)]

found this using the 2000-02-01-08 comm bits on winNT.

to repro,
1. go to above URL.
2. the AutoFill Password dialog appears. since i don't have a userid/passwd for 
this site, i just keep the fields blank.
3. uncheck the "Save these values" checkbox.
4. click the Cancel button.

result: the dialog disappears briefly...then reappears (text fields are blank, 
but the checkbox is selected again). doesn't go away. clicking either OK 
or Cancel will just repeat this result, too. forced to shutdown the browser 
(eg, close box widget). here's the console output:


*** Timing layout processes on url: 'chrome://global/content/commonDialog.xul',
webshell: 02D76DD0
change lock icon to unlock - new document
WEBSHELL+ = 7
Total (Layout + Page Load) Time (webshell=02DF1060): Real time 0:0:0, CP time 
0.
031
WEBSHELL+ = 8
Total (Layout + Page Load) Time (webshell=02E3E870): Real time 0:0:0, CP time 
0.
047
Reflow time (this=02DD5720): Real time 0:0:0, CP time 0.156
Frame construction plus style resolution time (this=02DD5720): Real time 0:0:0,
CP time 0.016
Style resolution time (this=02DD5720): Real time 0:0:0, CP time 0.000
Total (Layout + Page Load) Time (webshell=02D76DD0): Real time 0:0:0, CP time 
0.
203
commonDialogOnLoad
WEBSHELL- = 7
WEBSHELL+ = 8
Total (Layout + Page Load) Time (webshell=02E58220): Real time 0:0:0, CP time 
0.
047
Move window by 0,20
screen x 0screen y 0
! nsSecureBrowserUIImpl found: chrome://global/content/commonDialog.xul
change lock icon to unlock ?(chrome 0)

expected: not totally clear on what should happen upon cancelling (or entering 
invalid info), but the dialog should go away and then allow the user to 
continue using the browser.

Comment 1

[Stephen P. Morse]

This is a problem in http authentication code and not in single signon.  It's a 
dup of many other bugs such as 22561, 22566, and 25454.  Passing this off to 
Gagan who has http authentication.

Comment 2

[sairuh (rarely reading bugmail)]

tever, methinks this one's for you (do lemme know otherwise).

Comment 3

[sairuh (rarely reading bugmail)]

putting on beta1 radar... not sure if ranks as dogfood, quite... open to
comments there.

Comment 4

[Tom Everingham]

*** Bug 23517 has been marked as a duplicate of this bug. ***

Comment 5

[Tom Everingham]

*** Bug 25454 has been marked as a duplicate of this bug. ***

Comment 6

[Tom Everingham]

*** Bug 22566 has been marked as a duplicate of this bug. ***

Comment 7

[sairuh (rarely reading bugmail)]

from [e-mail]:

Platform: Solaris 2.7 && NT 
Release M13

On password dialog, when canceled, the site 401 error message does not
load, instead it's as if the user never requested the page.

Also on both NT and solaris the tab order puts the checkbox for "remember
this" ahead of the password box.

Comment 8

[Stephen P. Morse]

*** Bug 27148 has been marked as a duplicate of this bug. ***

Comment 9

[Gagan]

fix checked in.

Comment 10

[Tom Everingham]

verified:
NT 2000021408