Closed Bug 261527 Opened 20 years ago Closed 20 years ago

Firefox.app 1.0PR installs with world writable permissions on Mac OS X

Categories

(Firefox Build System :: General, defect, P3)

Product:
Firefox Build System
Component:
General
Platform:
PowerPC
macOS
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox1.0

People

(Reporter: john, Assigned: granrosebugs)

Details

(Keywords: fixed-aviary1.0)

Attachments

(1 file)

fix world writeable perms
674 bytes, patch
chase
: review+
bryner
: superreview+
asa
: approval-aviary+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; rv:1.7.3) Gecko/20040913 Firefox/0.10
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; rv:1.7.3) Gecko/20040913 Firefox/0.10

Firefox installs with 777 permisssions on all directories on Mac OS X.
Additionally, all directories inside Firefox.app are installed with 777 perms
and all executables are installed with 666 perms.

Reproducible: Always
Steps to Reproduce:
1. Install Firefox
2. Look at permissions of installed files


Actual Results:  
See description

Expected Results:  
Support files should be installed with 644 or 664 perms.
Directories and executables should be installed 755 or 775 perms.
Assignee: firefox → granrosebugs
Component: General → Build Config
Flags: blocking-aviary1.0mac?
Whiteboard: [sg:needconfirm]
yup, world writeable everywhere.  I see Netscape 7.2 perms look good on Mac (or
at least better), and Tbird 0.8 perms as well.  May just need to check the umask
on the build system, or this may get a little more complex.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P3
Whiteboard: [sg:needconfirm]
Perhaps the chmod should be done in mozilla/build/package/mac_osx/make-diskimage ?
Whiteboard: [sg:fix]
umask wasn't the problem, at least not on a per-system level.  fastest fix is
in make-diskimage as dbaron suggested.

can I get an amen on this patch?
Status: NEW → ASSIGNED
Whiteboard: [sg:fix] → needs review
Target Milestone: --- → Firefox1.0
Attachment #162719 - Flags: superreview?(bryner)
Attachment #162719 - Flags: review?(cmp)
Comment on attachment 162719 [details] [diff] [review]
fix world writeable perms

r=cmp
Attachment #162719 - Flags: review?(cmp) → review+
Comment on attachment 162719 [details] [diff] [review]
fix world writeable perms

a=asa for aviary checkin.
Attachment #162719 - Flags: approval-aviary+
Attachment #162719 - Flags: superreview?(bryner) → superreview+
fix checked in on trunk and aviary 1.0 branch.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Keywords: fixed-aviary1.0
Resolution: --- → FIXED
Whiteboard: needs review
Comment on attachment 162719 [details] [diff] [review]
fix world writeable perms

Could you please check in on the 1.7 branch as well? (a=dbaron)
landed on MOZILLA_1_7_BRANCH also
Flags: blocking-aviary1.0mac?
Group: security
Component: Build Config → General
Product: Firefox → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: