261637 - move security.properties into PSM

Status: VERIFIED FIXED

(Core :: Networking, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

netwerk/locale/en-US/security.properties is not used by necko. it is only used
by PSM (and camino). it should, therefore, live in PSM.

http://lxr.mozilla.org/mozilla/search?string=security.properties

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

patch

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

I'll also get someone to copy netwerk/resources/locale/en-US/security.properties
to security/manager/ssl/resources/locale/en-US/security.properties

Comment 3

[Benjamin Smedberg]

Comment on attachment 160656 [details] [diff] [review]
patch

You can't ship a chrome://communicator/ file from the security/manager dir,
because it's optionally built. You have to ship it to chrome://pipnss and
update the code references to the file.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch v2

Comment 5

[Benjamin Smedberg]

Comment on attachment 164162 [details] [diff] [review]
patch v2

In SecurityDialogs.mm can you move the #define above the function? (Or make it
a const char[]). In-functions defines are sooo ugly.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 164162 [details] [diff] [review]
patch v2

I'll move it above the function

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

justdave, could you do the cvs copy described in comment 2? thanks!

Comment 8

[Dave Miller [:justdave]]

(In reply to comment #7)
> justdave, could you do the cvs copy described in comment 2? thanks!

done.

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in camino/src/browser/SecurityDialogs.mm;
/cvsroot/mozilla/camino/src/browser/SecurityDialogs.mm,v  <--  SecurityDialogs.mm
new revision: 1.11; previous revision: 1.10
done
Checking in netwerk/resources/jar.mn;
/cvsroot/mozilla/netwerk/resources/jar.mn,v  <--  jar.mn
new revision: 1.11; previous revision: 1.10
done
Removing netwerk/resources/locale/en-US/security.properties;
/cvsroot/mozilla/netwerk/resources/locale/en-US/security.properties,v  <-- 
security.properties
new revision: delete; previous revision: 1.9
done
Checking in security/manager/boot/src/nsSecureBrowserUIImpl.cpp;
/cvsroot/mozilla/security/manager/boot/src/nsSecureBrowserUIImpl.cpp,v  <-- 
nsSecureBrowserUIImpl.cpp
new revision: 1.40; previous revision: 1.39
done
Checking in security/manager/boot/src/nsSecurityWarningDialogs.cpp;
/cvsroot/mozilla/security/manager/boot/src/nsSecurityWarningDialogs.cpp,v  <-- 
nsSecurityWarningDialogs.cpp
new revision: 1.11; previous revision: 1.10
done
Checking in security/manager/ssl/resources/jar.mn;
/cvsroot/mozilla/security/manager/ssl/resources/jar.mn,v  <--  jar.mn
new revision: 1.6; previous revision: 1.5
done

Comment 10

[benc]

V/per cvs comments.