261711 - Auto-whois data spews all over the current tab

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[James Ross]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20040926 Firefox/0.10
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20040926 Firefox/0.10

When someone PMs you, a tab opens (normally), and a /whois is automatically run
on the user. The whois information, however, spews all over the current view (or
the network's if you're looking at a completely different network).

Reproducible: Always
Steps to Reproduce:
1. Join, say, irc://moznet/
2. With another client, send a private message to the first client.

Actual Results:  
New tab opens, and whois results go over the network view.

Expected Results:  
New tab opens and whois results go into the new tab.

Comment 1

[James Ross]

Attachment: Spews whois data to user's tab (or current if the user has no tab)

No idea why I couldn't make this work before, this patch seems to work fine.

Comment 2

[James Ross]

Checked in.

Comment 3

[Thib]

[INFO]	Chatzilla 0.9.66 [Mozilla rv:1.7.3/20041001]
Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20041001 Firefox/0.10.1

It works but on Undernet there is a little glitch. Whois information on Undernet
(and possibly elsewhere) may include a numeric 330 line to indicate what
registered name the user is logged into, and this one line still shows up in
channel windows or elsewhere.

Steps to reproduce:
1. Log on to Undernet
2. Let someone logged into their Undernet account message you

Actual results:

In the new view for the query:
	===	stunk <~[e-mail]> “stunk”
	===	stunk: member of #Sanfrancisco
	===	stunk: attached to *.undernet.org “The Undernet Underworld”
	---	End of WHOIS information for stunk.

In the view that had focus at the time the query was received:
	===	stunk is logged in as ideal

It would be nice if the whole blurb of Whois text went to the new view, and not
only some lines of it.

Comment 4

[James Ross]

Attachment: Use same logic for on330 handler as other whois handlers

Comment 5

[James Ross]

Chcked in.