Closed Bug 261723 Opened 21 years ago Closed 21 years ago

[FIXr]nsImageFrame::AttributeChanged does unnecessary work

Categories

(Core :: Layout, defect, P2)

x86
Linux
defect

Tracking

()

RESOLVED FIXED
mozilla1.8beta1

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(1 file)

"width" and "height" already trigger reflows, without this method meddling...
Priority: -- → P2
Summary: nsImageFrame::AttributeChanged does unnecessary work → [FIX]nsImageFrame::AttributeChanged does unnecessary work
Target Milestone: --- → mozilla1.8beta
Attached patch PatchSplinter Review
Comment on attachment 160211 [details] [diff] [review] Patch roc, would you review? I've verified that <embed>, <img>, <object>, and <input> all handle dynamic changes to width/height via attr mapping.
Attachment #160211 - Flags: superreview?(roc)
Attachment #160211 - Flags: review?(roc)
Attachment #160211 - Flags: superreview?(roc)
Attachment #160211 - Flags: superreview+
Attachment #160211 - Flags: review?(roc)
Attachment #160211 - Flags: review+
Summary: [FIX]nsImageFrame::AttributeChanged does unnecessary work → [FIXr]nsImageFrame::AttributeChanged does unnecessary work
Fix checked in for 1.8a5.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: