261734 - installer crashes given any commandline arguments

Status: VERIFIED FIXED

(Firefox :: Installer, defect)

Description

[Andrew Schultz]

if the installer is given any commandline arguments, it attempts to parse them
(ParseArgs) before calling ParseConfig, which sets up gCtx and loads the
resources.  ParseArgs tries to use gCtx if any of the commandline arguments are
actually valid and the installer crashes.

Comment 1

[chris hofmann]

betting that this might be an easy fix.  if a patch appears renominate.

Comment 2

[Andrew Schultz]

Attachment: patch

parse config before args

Comment 3

[Daniel Veditz [:dveditz]]

Comment on attachment 160427 [details] [diff] [review]
patch

r=dveditz

How did this end up in the opposite order from the original version in
mozilla/xpinstall/wizard?

Comment 4

[Daniel Veditz [:dveditz]]

Comment on attachment 160427 [details] [diff] [review]
patch

would be good to get bryner to look anyway just in case there was a reason for
changing this in the first place. Plus I realized I probably don't have r=
authority here anyway.

Comment 5

[Brian Ryner (not reading)]

Comment on attachment 160427 [details] [diff] [review]
patch

I think the reason I reordered this is because gtk_init() needs to be called
before ParseConfig (because ParseConfig can call ErrorHandler which throws a
gtk dialog).  I was giving ParseArgs a crack at the arguments before gtk, but
since I don't think there's any conflict there, it would probably be best to do
it in this order:

gtk_init
ParseConfig
ParseArgs

make sense?

Comment 6

[Andrew Schultz]

> gtk_init
> ParseConfig
> ParseArgs
>
> make sense?

this breaks the idea that silent mode shouldn't try to open the display.

in Seamonkey, I made the Errorhandler check if the display was open and (if not)
to print the message to the console
http://lxr.mozilla.org/mozilla/source/xpinstall/wizard/unix/src2/nsXInstaller.cpp#434

Comment 7

[Brian Ryner (not reading)]

So, we could move gtk_init back to RunWizard, I guess, and bring over the fix to
print errors to the console if the display isn't [yet] open.

Comment 8

[Brian Ryner (not reading)]

Attachment: patch

something like this

Comment 9

[Andrew Schultz]

Comment on attachment 160599 [details] [diff] [review]
patch

looks good

Comment 10

[chris hofmann]

ok, lets take this if we can get it in quick.

Comment 11

[Daniel Veditz [:dveditz]]

Comment on attachment 160599 [details] [diff] [review]
patch

sr=dveditz

Comment 12

[Brian Ryner (not reading)]

Comment on attachment 160599 [details] [diff] [review]
patch

i'm going to interpret comment 10 as approval.

Comment 13

[Brian Ryner (not reading)]

checked in

Comment 14

[Andrew Schultz]

*** Bug 264191 has been marked as a duplicate of this bug. ***