261817 - missing plugin installer breaking on bad embed type

Status: RESOLVED WORKSFORME

(Toolkit Graveyard :: Plugin Finder Service, defect)

Description

[logan]

original discussion on the forums -
http://forums.mozillazine.org/viewtopic.php?t=134980

http://au.australianidol.yahoo.com/

<EMBED src="http://au.i1.yimg.com/australianidol.aunz.yimg.com/2004/flash/
inside_idol_orange.swf" quality="high"
pluginspage="http://www.macromedia.com/go/getflashplayer" type="application/x-
shockwave-flash" width=300 height=180></EMBED>

Yes, there's a break (newline or such) in the url and yes, there's a space in
the <embed type="application/x- shockwave-flash">. Correcting the embed type
allows the page to work.

Unless I'm totally wrong (hope not), the new plugin stuff is checking <embed
type> rather than content-type header from the server for the embed source. I
know that an additional HTTP request would be required to get the content-type
header, so I'm not sure that's very reasonable. However, if the request is
already made by the time the plugin stuff kicks in, maybe the embed type could
be ignored?

I'm not sure what the proper behavior should be and obviously it shouldn't be
grossly different from anything else in Mozilla, such as the character encoding
bits (content-type vs meta).

You guys may invalidate this bug rather quickly, which is ok.. I just wanted to
throw this out and see what you had to say.

Comment 1

[logan]

Attachment: flash file

Comment 2

[logan]

Attachment: testcase

The URL's no good anymore, here's a testcase.

Comment 3

[logan]

Attachment: testcase with proper type

Comment 4

[Johnny Stenback (:jst)]

This testcase doesn't work in older versions of Mozilla, nor in IE. Not sure we
should attempt to fix this...

Comment 5

[logan]

(In reply to comment #4)
> This testcase doesn't work in older versions of Mozilla, nor in IE. Not sure we
> should attempt to fix this...

Ugh. I can't get the broken testcase to work either, I swear it did.. I'm 100%
certain that http://au.australianidol.yahoo.com/'s broken html did work in
Mozilla. heh :S

Comment 6

[logan]

Alright, I've got it now. There must be something with the response headers for
the attached testcase.

http://www.gozer.org/test/mozilla/261817/

Check this out with the missing plugin installer enabled (doesn't work),
disabled (works), then Mozilla 1.x (works).

The first time around I didn't even notice this code worked with the plugin
installer disabled, because I didn't have the plugin installed.

Comment 7

[RNicoletto]

Testcases in comment 2, comment 3 and comment 6 are all WFM using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.12) Gecko/20101026 Firefox/3.6.12

Comment 8

[Justin Dolske [:Dolske]]

WFM per last comment.