261913 - Buddy icons not shown in message pane nor address book

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[M.J.G.]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; rv:1.7.3) Gecko/20040924 Firefox/0.10
Build Identifier: version 0.8 (20040927)

Mailnews/Thunderbird should display buddy icons as described in
http://www.mozilla.org/mailnews/arch/buddyicons.html, i.e. they should show up
in message view (headers expanded) and card view (addressbook).
Alas, nothing is shown.

Reproducible: Always
Steps to Reproduce:
1. Set up buddy icons (icons and addressbook card) as per
http://www.mozilla.org/mailnews/arch/buddyicons.html
2. Call up message view (expanded) or address card.
3. 
Actual Results:  
No buddy icons are visible. No visual difference to the case without buddy icons.


Expected Results:  
Display buddy icons.

Bug appeared at least in TB 0.7.
It is present in MailNews as well, reported as bug #254564.

I tested on Linux, but since it's bug in the JavaScript frontend code platform
is "all".

The fix is a two-liner in JavaScript.

Comment 1

[M.J.G.]

Attachment: fix to msgHdrViewOverlay.js

fix to msgHdrViewOverlay.js in messenger.jar!content/messenger

Comment 2

[M.J.G.]

Attachment: fix to abCardViewOverlay.js

fix to abCardViewOverlay.js in messenger.jar!content/messenger/addressbook/

Comment 3

[M.J.G.]

See also comment #1 to bug #254564 (same bug in mailnews), which describes the
XPCOM problem behind the bug and the solution proposed in the patch.

Comment 4

[Scott MacGregor]

thanks for the patches. Fix checked in branch and trunk.