Closed Bug 262065 Opened 20 years ago Closed 20 years ago

[altss] temporarily disable altss statusbar icon until 83663 fixed

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Version:
1.0 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox1.0

People

(Reporter: fantasai.bugs, Assigned: fantasai.bugs)

References

(
URL
)

Details

(Keywords: fixed-aviary1.0)

Attachments

(1 file, 1 obsolete file)

patch (also removes icon code from winstripe/pinstripe)
8.86 KB, patch
bugs
: review+
bugs
: approval-aviary+
Details | Diff | Splinter Review 
#ifdef out the alternate style sheet statusbar icon until bug 83663 / bug 216537
are fixed. (Page Style submenu under View should be left intact.)
Status: NEW → ASSIGNED
Flags: blocking-aviary1.0?
Target Milestone: --- → Firefox1.0
Need this for 1.0 -- who will #ifdef out the altss statusbar icon?

/be
Flags: blocking-aviary1.0? → blocking-aviary1.0+
Would it make sense to hold off on this until the fix for bug 258800 is checked
in and verified?  Otherwise that might be difficult to test unless that would be
testable on the trunk (assuming this ifdef is for the branch only).
Given that they're disabling the whole status bar now, I think we should be ok. :)
The status bar is only being removed in Print Preview, which has nothing to do
with the two bugs in the original post.
Ack, comment #3 was directed at comment #2 and not this bug itself.  Please
ignore comment #4.  Sorry about the bugspam.
Attached patch patch (obsolete) — — Splinter Review 

    
  

        Attachment #160949 -
        Flags: review?(bugs)

    
  
Whiteboard: [have patch] - need review ben

    
    

    
  


  

        Attachment #160949 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 161214 [details] [diff] [review]
patch (also removes icon code from winstripe/pinstripe)

r+a=ben@mozilla.org

        Attachment #161214 -
        Flags: review+

        Attachment #161214 -
        Flags: approval-aviary+

    
  

        Attachment #160949 -
        Flags: review?(bugs)

    
  
Whiteboard: [have patch] - need review ben → [have patch, review, approval] - needs checkin

    
    

    
  
Since no active development can be seen in bug 83663 / bug 216537, does this
mean that there will not be any styleswitcher icon in Firefox 1.0?

    
    

    
  
That is correct. Even if 83663 had a fix in hand, it wouldn't be checked into the
1.0 branch: it requires too many changes to the style system infrastructure--
stuff that should not be added to a "stable" branch.
The Page Style submenu will remain, though: you can still switch styles from there.

    
    

    
  
Fixed by dbaron's checkin
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Whiteboard: [have patch, review, approval] - needs checkin

    
  
Keywords: fixed-aviary1.0

    
    

    
  
vrfy'd fixed with 20041008(09/05)-0.9+ bits on linux fc2 and mac os x 10.3.5.
View > Page Style submenu works fine as a substitute.
Status: RESOLVED → VERIFIED

    
    

    
  
Any chance to get the statusbar icon reactivated as a hidden pref?

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: