[ActiveX] Add IHTMLTable and related interfaces implementation

RESOLVED INVALID

Status

Core Graveyard
Embedding: ActiveX Wrapper
--
enhancement
RESOLVED INVALID
14 years ago
6 years ago

People

(Reporter: Alexandre Trémon, Unassigned)

Tracking

Trunk
x86
Windows 2000

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 4 obsolete attachments)

(Reporter)

Description

14 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040616
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a2) Gecko/20040817

IHTMLTable, IHTMLTableCaption, IHTMLTableCell, IHTMLTableRow

Reproducible: Always
Steps to Reproduce:
(Reporter)

Updated

14 years ago
Assignee: adamlock → atremon
(Reporter)

Comment 1

14 years ago
Created attachment 160467 [details] [diff] [review]
declaration for IHTMLTable, IHTMLTableCaption, IHTMLTableCell, IHTMLTableRow

And related (IHTMLTable2, etc.).
These interfaces are defined for IE 4.
(Reporter)

Comment 2

14 years ago
Created attachment 160468 [details] [diff] [review]
IHTMLDocument2::CreateElement & IHtmlDomNode::CloneNode implementation

In common, implementation of methods like InsertReow, CretaeCaption,
InsertCell, get_Cells, etc. Also modified CIEHtmlSelectionObject::get_type
method for table case.

VB example:
Private Sub Command1_Click()
    Dim doc As IHTMLDocument2
    Set doc = MozillaBrowser1.Document
    Dim elt As IHTMLElement, node As IHTMLDOMNode
    Set elt = doc.body
    Set node = elt
    Dim table As IHTMLTable, row As IHTMLTableRow, cell As IHTMLTableCell
    Set table = doc.createElement("table")
    Set row = table.insertRow(0)
    node.appendChild table
    Set cell = row.insertCell(0)
    Set elt = cell
    elt.innerText = "toto"
    Set elt = node
    table.bgColor = "005599"
End Sub

Private Sub Form_Load()
    MozillaBrowser1.Navigate "about:blank"
End Sub
(Reporter)

Comment 3

14 years ago
Created attachment 160492 [details]
IHTMLTable2, IHTMLRow2 and IHTMLRowMetrics are defined for IE5

Need declaration for compile with old Sdk
(Reporter)

Comment 4

14 years ago
Created attachment 160499 [details] [diff] [review]
Added IEHtmlTableDecl.h and use of OLE2CW & nsDependentString
Attachment #160468 - Attachment is obsolete: true
(Reporter)

Comment 5

14 years ago
Created attachment 160501 [details] [diff] [review]
Added IEHtmlTableDecl.h

IHtmlTable.cpp & .h were not created when applying patch
Attachment #160467 - Attachment is obsolete: true
(Reporter)

Comment 6

14 years ago
Comment on attachment 160501 [details] [diff] [review]
Added IEHtmlTableDecl.h

Adam, can you review these patches for me (160501 &160492 & 160499) ?
Attachment #160501 - Flags: review?(adamlock)

Comment 7

14 years ago
Comment on attachment 160501 [details] [diff] [review]
Added IEHtmlTableDecl.h

Same concerns as for bug 262237 concerning IE5.0+ interfaces in a VC++ 98
standard set of include headers.
Attachment #160501 - Flags: review?(adamlock) → review-
(Reporter)

Comment 8

14 years ago
Created attachment 161865 [details]
missing #endif and guids
Attachment #160492 - Attachment is obsolete: true
(Reporter)

Comment 9

14 years ago
Created attachment 163426 [details] [diff] [review]
no tabs 

and removed stupid thing about the table in the IHtmlSelection::get_type method
(Reporter)

Updated

14 years ago
Attachment #160501 - Attachment is obsolete: true
(Reporter)

Comment 10

14 years ago
(In reply to comment #7)
> (From update of attachment 160501 [details] [diff] [review])
> Same concerns as for bug 262237 concerning IE5.0+ interfaces in a VC++ 98
> standard set of include headers.
> 

Adam, what missing interfaces did you see besides Table2, tableRow2 and
TableRowMetrics ?
I checked that all others where defined for IE4.
(Reporter)

Updated

14 years ago
Attachment #160499 - Flags: review?(adamlock)
(Reporter)

Updated

14 years ago
Attachment #161865 - Flags: review?(adamlock)
(Reporter)

Updated

14 years ago
Attachment #163426 - Flags: review?(adamlock)
QA Contact: dunn5557 → activex
The ActiveX embedding API was removed in bug 662023 and friends, making this INVALID.

[Filter bugspam on activexinvalid]
Assignee: atremon → nobody
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → INVALID
(Assignee)

Updated

6 years ago
Component: Embedding: ActiveX Wrapper → Embedding: ActiveX Wrapper
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.