262074 - [ActiveX] Add IHTMLTable and related interfaces implementation

Status: RESOLVED INVALID

(Core Graveyard :: Embedding: ActiveX Wrapper, enhancement)

Description

[Alexandre Trémon]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040616
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a2) Gecko/20040817

IHTMLTable, IHTMLTableCaption, IHTMLTableCell, IHTMLTableRow

Reproducible: Always
Steps to Reproduce:

Comment 1

[Alexandre Trémon]

Attachment: declaration for IHTMLTable, IHTMLTableCaption, IHTMLTableCell, IHTMLTableRow

And related (IHTMLTable2, etc.).
These interfaces are defined for IE 4.

Comment 2

[Alexandre Trémon]

Attachment: IHTMLDocument2::CreateElement & IHtmlDomNode::CloneNode implementation

In common, implementation of methods like InsertReow, CretaeCaption,
InsertCell, get_Cells, etc. Also modified CIEHtmlSelectionObject::get_type
method for table case.

VB example:
Private Sub Command1_Click()
    Dim doc As IHTMLDocument2
    Set doc = MozillaBrowser1.Document
    Dim elt As IHTMLElement, node As IHTMLDOMNode
    Set elt = doc.body
    Set node = elt
    Dim table As IHTMLTable, row As IHTMLTableRow, cell As IHTMLTableCell
    Set table = doc.createElement("table")
    Set row = table.insertRow(0)
    node.appendChild table
    Set cell = row.insertCell(0)
    Set elt = cell
    elt.innerText = "toto"
    Set elt = node
    table.bgColor = "005599"
End Sub

Private Sub Form_Load()
    MozillaBrowser1.Navigate "about:blank"
End Sub

Comment 3

[Alexandre Trémon]

Attachment: IHTMLTable2, IHTMLRow2 and IHTMLRowMetrics are defined for IE5

Need declaration for compile with old Sdk

Comment 4

[Alexandre Trémon]

Attachment: Added IEHtmlTableDecl.h and use of OLE2CW & nsDependentString

Comment 5

[Alexandre Trémon]

Attachment: Added IEHtmlTableDecl.h

IHtmlTable.cpp & .h were not created when applying patch

Comment 6

[Alexandre Trémon]

Comment on attachment 160501 [details] [diff] [review]
Added IEHtmlTableDecl.h

Adam, can you review these patches for me (160501 &160492 & 160499) ?

Comment 7

[Adam Lock]

Comment on attachment 160501 [details] [diff] [review]
Added IEHtmlTableDecl.h

Same concerns as for bug 262237 concerning IE5.0+ interfaces in a VC++ 98
standard set of include headers.

Comment 8

[Alexandre Trémon]

Attachment: missing #endif and guids

Comment 9

[Alexandre Trémon]

Attachment: no tabs

and removed stupid thing about the table in the IHtmlSelection::get_type method

Comment 10

[Alexandre Trémon]

(In reply to comment #7)
> (From update of attachment 160501 [details] [diff] [review])
> Same concerns as for bug 262237 concerning IE5.0+ interfaces in a VC++ 98
> standard set of include headers.
> 

Adam, what missing interfaces did you see besides Table2, tableRow2 and
TableRowMetrics ?
I checked that all others where defined for IE4.

Comment 11

[Ed Morley [:emorley]]

The ActiveX embedding API was removed in bug 662023 and friends, making this INVALID.

[Filter bugspam on activexinvalid]