editing a buglist from a tabular report goes to wrong page

RESOLVED FIXED in Bugzilla 2.18

Status

()

Bugzilla
Query/Bug List
RESOLVED FIXED
13 years ago
5 years ago

People

(Reporter: robzilla, Assigned: gerv)

Tracking

2.18
Bugzilla 2.18
Bug Flags:
approval +
blocking2.20 -
approval2.18 +
blocking2.18 -

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

13 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.1) Gecko/20040707
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.1) Gecko/20040707

When you run a tabular report, and then click on one of the numbers in a table
to get a bug list, and then click on the "Edit search" link at the bottom of that
bug list, it takes you back to the "Generate Tabular Report" page, instead of
the query page.

Reproducible: Always
Steps to Reproduce:





I used the following to fix this problem (sorry, my installation is too
customized to give a usable patch)
       
      [% editqueryurl = urlquerypart FILTER html;
         editqueryurl = editqueryurl.replace('&?query_format=.*?(&|$)','&');
         editqueryurl = editqueryurl.replace('&+', '&');
         editqueryurl = editqueryurl.replace('(^&)|(&$)', '');
      %]
...
     <a href="query.cgi?[% editqueryurl %]......
(Reporter)

Updated

13 years ago
Version: unspecified → 2.18
(Reporter)

Updated

13 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Reporter)

Comment 1

13 years ago
Created attachment 161186 [details] [diff] [review]
Patch v1

I think any solution to this problem would be a hack, but this is probably the
better hack.  In buglist.cgi, simply remove "query_format=report-table" from
$::buffer, and it's all good.
Assignee: justdave → rsiklos
Status: NEW → ASSIGNED
(Reporter)

Updated

13 years ago
Attachment #161186 - Flags: review?
(Reporter)

Updated

13 years ago
Flags: blocking2.20?
Flags: blocking2.18?
(Reporter)

Updated

13 years ago
OS: Windows XP → All
Hardware: PC → All
Attachment #161186 - Flags: review? → review?(gerv)
Flags: blocking2.20?
Flags: blocking2.20-
Flags: blocking2.18?
Flags: blocking2.18-
Whiteboard: will accept for 2.18 branch, not blocking release though.
Target Milestone: --- → Bugzilla 2.18
(Assignee)

Comment 2

13 years ago
Created attachment 163251 [details] [diff] [review]
Patch v.2

Actually, this is the correct fix - to not put it in there in the first place
:-) 

Rob: thanks for your bug report(s), and your patch(es). Would you be able to
review this for my by verifying that if you remove your hack, and add mine, it
still fixes the problem for you?

Gerv
Assignee: rsiklos → gerv
Attachment #161186 - Attachment is obsolete: true
(Assignee)

Updated

13 years ago
Attachment #161186 - Flags: review?(gerv) → review-
(Assignee)

Updated

13 years ago
Attachment #163251 - Flags: review?(rsiklos)
(Reporter)

Comment 3

13 years ago
Comment on attachment 163251 [details] [diff] [review]
Patch v.2

looks good to me Gerv.	Thanks!
Attachment #163251 - Flags: review?(rsiklos) → review+
(Reporter)

Updated

13 years ago
Flags: approval?
Flags: approval2.18?
Flags: approval?
Flags: approval2.18?
Flags: approval2.18+
Flags: approval+

Comment 4

13 years ago
Checking in report.cgi;
/cvsroot/mozilla/webtools/bugzilla/report.cgi,v  <--  report.cgi
new revision: 1.27; previous revision: 1.26
done

Checking in report.cgi;
/cvsroot/mozilla/webtools/bugzilla/report.cgi,v  <--  report.cgi
new revision: 1.24.2.2; previous revision: 1.24.2.1
done
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Whiteboard: will accept for 2.18 branch, not blocking release though.
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.