262182 - editing a buglist from a tabular report goes to wrong page

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Rob Siklos [:robzilla]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.1) Gecko/20040707
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.1) Gecko/20040707

When you run a tabular report, and then click on one of the numbers in a table
to get a bug list, and then click on the "Edit search" link at the bottom of that
bug list, it takes you back to the "Generate Tabular Report" page, instead of
the query page.

Reproducible: Always
Steps to Reproduce:





I used the following to fix this problem (sorry, my installation is too
customized to give a usable patch)
       
      [% editqueryurl = urlquerypart FILTER html;
         editqueryurl = editqueryurl.replace('&?query_format=.*?(&|$)','&');
         editqueryurl = editqueryurl.replace('&+', '&');
         editqueryurl = editqueryurl.replace('(^&)|(&$)', '');
      %]
...
     <a href="query.cgi?[% editqueryurl %]......

Comment 1

[Rob Siklos [:robzilla]]

Attachment: Patch v1

I think any solution to this problem would be a hack, but this is probably the
better hack.  In buglist.cgi, simply remove "query_format=report-table" from
$::buffer, and it's all good.

Comment 2

[Gervase Markham [:gerv]]

Attachment: Patch v.2

Actually, this is the correct fix - to not put it in there in the first place
:-) 

Rob: thanks for your bug report(s), and your patch(es). Would you be able to
review this for my by verifying that if you remove your hack, and add mine, it
still fixes the problem for you?

Gerv

Comment 3

[Rob Siklos [:robzilla]]

Comment on attachment 163251 [details] [diff] [review]
Patch v.2

looks good to me Gerv.	Thanks!

Comment 4

[Vlad Dascalu]

Checking in report.cgi;
/cvsroot/mozilla/webtools/bugzilla/report.cgi,v  <--  report.cgi
new revision: 1.27; previous revision: 1.26
done

Checking in report.cgi;
/cvsroot/mozilla/webtools/bugzilla/report.cgi,v  <--  report.cgi
new revision: 1.24.2.2; previous revision: 1.24.2.1
done