26220 - menu key commands should only fire one event per kepress

Status: RESOLVED WONTFIX

(Core :: XUL, defect, P3)

Description

[staublis]

if you press the keycombination "ctrl+n" and let dem pressed down for more then
a second (what some slow beginner users like my mother will do), a big count of
new windows opens...

solution: the key_down event (dont know how it's called correctly) should only
be called once

i think there is general problems with all keycombinations. hmm what will happen
if you want to send a mail with ctrl+enter and press the combination for a
longer time...

Comment 1

[cbegle]

Reproduced.  It's not just true for Ctrl-N, but other things, like adding 
bookmarks.
1. Open your bookmarks sidebar so you can watch it.
2. On NT, press ctrl-D, and hold for a full second or two.  
3. watch your bookmarks list be filled with multiple entries for the current 
URL.  should only add the URL once.

Opening windows is worse of course since it sucks up so many resources.

Comment 2

[Mike Pinkerton (not reading bugmail)]

key stuff? chris?

Comment 3

[saari (gone)]

key down will continue to fire while the key is down. What things like bookmarks need to go on is key press instead

Comment 4

[verah (gone)]

Reassigning as per Don.

Comment 5

[don]

Move to M21 target milestone.

Comment 6

[sairuh (rarely reading bugmail)]

*spam*: transferring current XP Menu bugs over to jrgm, the new component owner.
feel free to add me to the cc list (unless am the Reporter) of any of these, if
you have any questions/etc.

Comment 7

[Blake Ross]

back to component owner

Comment 8

[Mike Pinkerton (not reading bugmail)]

um, i disagree this is even a bug. It's the standard behavior on macOS to keep
repeating menu commands while the cmdkey combo is pressed.

what about other platforms (where i assume people are complaining)

Comment 9

[John Morrison]

MS-IE5 and MS-Excel (as well as Nav4x and NS6) will continue to execute ctrl-N
while that key combo is held down (e.g., Excel will happily create 500 new 
workbooks for you, if you ask it to).

Comment 10

[John Morrison]

The bookmarks behaviour that cbegle noted way back when, is no longer 
reproducible (possibly because this was handled in application-level code
at some point; there is a kludge in navigator.js to prevent multiple bookmarks 
windows from being opened).

Comment 11

[Simon Fraser [no longer active]]

Isn't this a dup of bug 71074?

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.

Comment 13

[Sylvestre Ledru [:Sylvestre]]

XUL + no activity for a while. Closing.