262266 - Marking bugs as ASSIGNED from change-multiple fails if musthavemilestoneonaccept is enabled

Status: RESOLVED DUPLICATE of bug 220156

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Vlad Dascalu]

I get

Software error: Can't use an undefined value as an ARRAY reference at
process_bug.cgi line 884

when I try to change multiple bugs from the same product (only one product
defined), which is secured with Mandatory/Mandatory restriction (I don't know if
that helps or is related to it). The only change that I try to make is to assign
the bugs to me. There are bugs that are new and others that are assigned to me
already.

Line 884 is the first "if" line in the following block:

    /^accept$/ && CheckonComment( "accept" ) && do {
        DoConfirm();
        ChangeStatus('ASSIGNED');
        if (Param("musthavemilestoneonaccept") &&
                scalar(@{$::target_milestone{$::FORM{'product'}}}) > 1) {
            if (Param("usetargetmilestone")) {
                $requiremilestone = 1;
            }
        }
        last SWITCH;
    };

Comment 1

[Dave Miller [:justdave]]

you have "musthavemilestoneonaccept" turned on don't you?

I don't believe the change-multiple form passes the product in unless you
explicitly set it on the form...  which means $::FORM{'product'} is going the be
"--do_not_change--" or something similar.   eeek.

I don't think a fix for this is worthy of backporting to 2.16, it's likely to be
too involved to be a low-risk fix.  I'll consider it for 2.18 at such point as
we have a fix ready and I can see how involved it is.  I won't hold release for it.

Comment 2

[Frédéric Buclin]

*** This bug has been marked as a duplicate of 220156 ***

Comment 3

[Dave Miller [:justdave]]

clearing target for resolved other than fixed, so they'll show up as untriaged
if they ever get reopened.