262304 - XML Parsing Error in migration/import preventing trunk FF from launching Import Wizard.

Status: VERIFIED FIXED

(Firefox :: Migration, defect)

Description

[Tracy Walker [:tracy]]

Seen on:
Windows trunk build 2004-09-30-08-trunk 
Mac trunk build 2004-09-30-07-trunk

-clean install (remove all profiles) to get migration dialog on launch.
-launch FF

or

-File | Import

tested results:
XML Parsing Error: unidentified entity
Location: chrome://browser/content/migration/migration.xul
Line Number 23, column 53:

   <description id="importBookmarkss" hidden="true">&importFromBookmarks.label;
</description>
----------------------------------------------------^

A workaround to do other testing is to re-launch without blowing away the
profile dir.  This avoids the migration dialog.

Comment 1

[Alex Vincent [:WeirdAl]]

http://lxr.mozilla.org/mozilla/source/browser/locales/en-US/chrome/browser/migration/migration.dtd

This shows the importFromBookmarks.label entity.

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/locales/en-US/chrome/browser/migration/migration.dtd&rev=&cvsroot=/cvsroot

This doesn't.

What's going on here?

Comment 2

[Alex Vincent [:WeirdAl]]

Checkins to cvs according to bonsai on 2004-09-29 12:08 did not include any
changes to migration.dtd.

http://tinderbox.mozilla.org/bonsai/cvsquery.cgi?module=allrepositories&branch=&dir=&file=&who=ben%25bengoodger.com&sortby=Date&hours=2&date=week

This was apparently an attempt to fix bug 249302; the bustage reported here is
likely a regression from that.  (If we believe bonsai and not lxr...)

Comment 3

[Alex Vincent [:WeirdAl]]

fyi: the first link in comment 1 should be:
http://lxr.mozilla.org/aviarybranch/source/browser/locales/en-US/chrome/browser/migration/migration.dtd

But LXR still disagrees with bonsai.

Comment 4

[Bill Gianopoulos [:WG9s]]

re comment #3, if this is an issue in trunk builds, why would you be looking at
the aviarybranch source in lxr?

Comment 5

[Alex Vincent [:WeirdAl]]

Point taken.  Now here's the funny part.

Yesterday, LXR and bonsai didn't agree (per comment 1's links, which according
to #developers are the right set).  Today, they do...

What they're telling me is that the entity importFromBookmarks.label isn't in
the DTD file.  But it's referenced in the XUL document.

Trivial to fix, really, but I'm not on a machine where I can whip this up.  We
just need to add the entity to migration.dtd.

Comment 6

[Kenny Lee]

I am getting the same error too. It has been like this since a few builds back.

Comment 7

[Ryan Polk (Quark)]

As part of the fix for bug 249302, Ben seems to have checked in all of the
migration.js and migration.xul part of the Bookmarks -> Import changes (vlad had
only put them on aviary).  That was bug 255151.

Doing a quick scan, it looks like the changes to
/browser/components/bookmarks/content/bookmarks.js and
/browser/locales/en-US/chrome/browser/migration/migration.dtd were not checked
in to trunk.

Comment 8

[Ryan Polk (Quark)]

Also note when bookmarks.js gets patched, the change in bug 259039 should also
be put in to prevent Mac Import from being broken.

Comment 9

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

I just landed the missing bookmarks.js and migration.dtd changes on trunk
(bookmarks.js with additional mac patch).

Comment 10

[Tracy Walker [:tracy]]

marking fixed as seen on Mac and Windows trunk builds 10/07

Migration and import dialogs appear without error.

Comment 11

[Tracy Walker [:tracy]]

verified with branch builds from 10/08