Closed Bug 262373 Opened 20 years ago Closed 19 years ago

Fresh installed extensions cause software update to fail

Categories

(Toolkit :: Application Update, defect)

defect
Not set
major

Tracking

()

RESOLVED FIXED

People

(Reporter: tonglebeak, Assigned: robert.strong.bugs)

References

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040913 Firefox/0.10
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040913 Firefox/0.10

After installing a new extension, not restarting Firefox. If you attempt to do a
Firefox update, the update will hang and complete itself. This only happens
though after an extension is installed, but Firefox is not restarted. However,
someone might want to update their extensions after installing a new one, and do
just one restart to get them all updated/installed, so this should be fixed.

Reproducible: Always
Steps to Reproduce:
1.Install a new extension, WITHOUT RESTARTING
2.Attempt to do a Firefox update
3.Update will hang and not complete its check

Actual Results:  
Update hangs, doesn't complete its update check.

Expected Results:  
Performed the update normally.
Confirmed with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3)
Gecko/20041008 Firefox/0.10.1
Status: UNCONFIRMED → NEW
Ever confirmed: true
Version: unspecified → Trunk
Flags: blocking-aviary1.1+
Whiteboard: [asaP1]
confirmed

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050422
Firefox/1.0+
can anyone reproduce this with a current build? please re-nominate if you can.
thanks. 
Flags: blocking-aviary1.1+ → blocking-aviary1.1-
Whiteboard: [asaP1]
(In reply to comment #3)
> can anyone reproduce this with a current build? please re-nominate if you can.
> thanks. 

I had wanted to make sure the software update landed before trying it again and
posting about it.

I can reproduce with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b3)
Gecko/20050711 Firefox/1.0+ ID:2005071106

Installed the Show IP extension, ran the extension update, it would hang at
different spots during different tests, but it never fully went through. After
restarted for the Show IP extension, extension update ran as normal.

Re-nominating per asa's comment.
Flags: blocking-aviary1.1- → blocking-aviary1.1?
We need to investigate/fix this before b4 if its reproduceable.
Flags: blocking-aviary1.1? → blocking1.8b4+
I believe this has been fixed by the patch that landed in bug 299887. I will
verify in the next day or two if someone doesn't beat me to it.
It is almost fixed... all it took is two more lines. I have a patch and I'll
submit it this weekend.
Attached patch simple patchSplinter Review
Benjamin - this calls updateProperty for updateable which was added in bug
299887. This also fixes bug 279564.
Assignee: bugs → rob_strong
Status: NEW → ASSIGNED
Attachment #189661 - Flags: review?(benjamin)
oops... I meant to say it also fixes bug 270564. :/
Attachment #189661 - Flags: review?(benjamin)
Attachment #189661 - Flags: review+
Attachment #189661 - Flags: approval1.8b4+
landed on trunk. As long as all callers for extension update use
getUpdateableItemList this should no longer be a problem and I verified this
using the Extension Manager itself. I'll do a more thorough job verifying this
in the next couple of days if someone else doesn't beat me to it. If there are
any further problems please file a new bug and assign it to me and I'll fix the
call sites.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: