262675 - remove ! important from option:checked in forms.css

Status: RESOLVED WONTFIX

(Core :: Layout: Form Controls, defect)

Description

[Anne (:annevk)]

See bug 35246 comment 33 for more information. Attachment 160002 [details] [diff] has a patch and
I believe attachment 145442 [details] can be used as a simple test case.

Note that the patch already got sr=dbaron, I believe this one only needs to be
checked in as part of this bug.

Comment 1

[Justin Wood (:Callek)]

Attachment: Fix as suggested

Here is the fix I had already created, I leave it to anne or others to convince
the people I will r?/sr? that this is needed if they choose to be leary

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 161339 [details] [diff] [review]
Fix as suggested

No one ever addressed the issue I raised in bug bug 35246 comment 33.

Marking r- pending some response on that.  (Note that this already has ok from
dbaron, so no need to spam him with more review requests).

Comment 3

[Anne (:annevk)]

Justin, could you please check this in. It already had r=sr=dbaron so there is
no reason to not check it in.

Sorry for the late response, by the way. I was disconnected for about 7 weeks
where I was told it would last 2 weeks.

Comment 4

[Boris Zbarsky [:bzbarsky]]

> It already had r=sr=dbaron

No, it doesn't.  I has sr=dbaron conditinal on r= from me and r- from me.  If
you think it should go into the tree, please address the review comments.

Comment 5

[Hixie (not reading bugmail)]

(Even if a patch got r=, sr=, moa=, and a=, an r- from anyone else, especially a
peer, should be enough to stop the check-in or cause a back-out. It just makes
no sense to check a patch in if a peer saw something wrong with it.)

Comment 6

[Justin Wood (:Callek)]

marking WONTFIX for now, per anne (in IRC) and per bz's comments