If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

remove ! important from option:checked in forms.css

RESOLVED WONTFIX

Status

()

Core
Layout: Form Controls
RESOLVED WONTFIX
13 years ago
13 years ago

People

(Reporter: annevk, Assigned: Callek)

Tracking

({css3, testcase})

Trunk
css3, testcase
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [hasPatch] [needs External Persuasion])

Attachments

(1 attachment)

(Reporter)

Description

13 years ago
See bug 35246 comment 33 for more information. Attachment 160002 [details] [diff] has a patch and
I believe attachment 145442 [details] can be used as a simple test case.

Note that the patch already got sr=dbaron, I believe this one only needs to be
checked in as part of this bug.
(Assignee)

Updated

13 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

13 years ago
Created attachment 161339 [details] [diff] [review]
Fix as suggested

Here is the fix I had already created, I leave it to anne or others to convince
the people I will r?/sr? that this is needed if they choose to be leary
(Assignee)

Updated

13 years ago
Attachment #161339 - Flags: superreview?(dbaron)
Attachment #161339 - Flags: review?(bzbarsky)
Comment on attachment 161339 [details] [diff] [review]
Fix as suggested

No one ever addressed the issue I raised in bug bug 35246 comment 33.

Marking r- pending some response on that.  (Note that this already has ok from
dbaron, so no need to spam him with more review requests).
Attachment #161339 - Flags: superreview?(dbaron)
Attachment #161339 - Flags: superreview-
Attachment #161339 - Flags: review?(bzbarsky)
Attachment #161339 - Flags: review-
(Assignee)

Updated

13 years ago
Whiteboard: [hasPatch] [needs External Persuasion]
(Reporter)

Comment 3

13 years ago
Justin, could you please check this in. It already had r=sr=dbaron so there is
no reason to not check it in.

Sorry for the late response, by the way. I was disconnected for about 7 weeks
where I was told it would last 2 weeks.
> It already had r=sr=dbaron

No, it doesn't.  I has sr=dbaron conditinal on r= from me and r- from me.  If
you think it should go into the tree, please address the review comments.
(Even if a patch got r=, sr=, moa=, and a=, an r- from anyone else, especially a
peer, should be enough to stop the check-in or cause a back-out. It just makes
no sense to check a patch in if a peer saw something wrong with it.)
(Assignee)

Comment 6

13 years ago
marking WONTFIX for now, per anne (in IRC) and per bz's comments
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.