262694 - Installation fails (Install **FAILED** with error -229)

Status: RESOLVED FIXED

(Mozilla Localizations :: de / German, defect)

Description

[Marcus Staender]

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; de-AT; rv:1.7.3) Gecko/20040918
Build Identifier: Mozilla/5.0 (OS/2; U; Warp 4.5; de-AT; rv:1.7.3) Gecko/20040918

When I rebuild the XPI without the global/local question, the install succeeds
(but quits with similar error message)

Here is the Install.Log after changing the INSTALL.JS


     ** language pack installation: platform type detected as: unix
     Deutsch (version 1.7)
     -------

     ** initInstall: 0 (SUCCESS)
     ** fProgram: J:\ANWENDUNGEN\MOZILLA\
     ** searchplugins path detected as: J:\ANWENDUNGEN\MOZILLA\searchplugins\
     ** addDirectory() for chrome returned: 0 (SUCCESS)
     ** addDirectory() for defaults returned: 0 (SUCCESS)
     ** addDirectory() for searchplugins returned: 0 (SUCCESS)
     ** addDirectory() for myspell returned: 0 (SUCCESS)
     [1/55]	Replacing: J:\ANWENDUNGEN\MOZILLA\chrome\de-win.jar
     [2/55]	Replacing: J:\ANWENDUNGEN\MOZILLA\chrome\de-mac.jar
     [3/55]	Replacing: J:\ANWENDUNGEN\MOZILLA\chrome\de-AT.jar
.....      
     [54/55]	Register Locale:
jar:resource:/chrome/de-unix.jar!/locale/de-AT/global-platform/
     [55/55]	Register Locale:
jar:resource:/chrome/de-unix.jar!/locale/de-AT/communicator-platform/
     ** performInstall() returned: 0 (SUCCESS)
     ** Line: 0	can't convert Error to string
     ** Line: 402	messages has no properties

     Install **FAILED** with error -229  --  2004-10-03 14:19:53



Reproducible: Always
Steps to Reproduce:
1.Start Mozilla 1.6, 1.7 or 1.7.3
2.Open the correct Language Pack XPI
3.Get the message "Install failed (Script error)"

Actual Results:  
Language Pack is not installed

Expected Results:  
Do you really want to know?

Comment 1

[Robert Kaiser]

Hmm...

-229 is SCRIPT_ERROR

The interesting thing is getting the message bundle can be no problem, as
deciding from the log, it shows the dialog with the message from there, you
select "OK" (global install), and this performs correctly.
Deciding from the log, it should even be installed correctly.
I don't see "messages" in line 402 in the 1.7.3 German install.js script, so I
wonder though what's happening exactly. The nearest thing there is line 406,
though I believe it has to go to line 409 in your case, where it just should
display an alert window telling that installation was successful (as your log says).

You even should be able to use the localization, even though this error happened
(if this log is really what happens)... Could you try that?

Comment 2

[Marcus Staender]

(In reply to comment #1)
> Hmm...
> 
> -229 is SCRIPT_ERROR
> 

This is the original Install.LOG result before
I modified the script:

     ** language pack installation: platform type detected as: unix
     Deutsch (version 1.7)
     -------

     ** initInstall: 0 (SUCCESS)
     ** fProgram: J:\ANWENDUNGEN\MOZILLA\
     ** searchplugins path detected as: J:\ANWENDUNGEN\MOZILLA\searchplugins\
     ** Line: 0	can't convert Error to string
     ** Line: 297	messages has no properties

     Install **FAILED** with error -229  --  2004-10-03 14:13:23


I deleted the IF-clause so that the script around line 297 looked as follows

  var tellRestart = 0;

    wantGlobalInstall = 1;

  if (wantGlobalInstall) {

This allowed German language support for the first time since
the last couple of Mozilla updates...

There obviously is a problem with dialog boxes and retrieving
message text resources....

BTW: The standalone spellchecker XPI works without problems.

Comment 3

[Robert Kaiser]

Hmm, could you try what happens if you wrap the block you deleted with and if
instead, i.e.

if (messages) {
  if (confirm(messages.install_confirm)) {
    wantGlobalInstall = 1;
  }
  else {
    wantGlobalInstall = 0;
  }
}

does it go over it then? (and only fail after installing)

And btw, you tried installing by opening the XPI from a running Mozilla, right?

Comment 4

[Marcus Staender]

Result from "wrapping":
     ** Line: 307	wantGlobalInstall is not defined

Of course it's installed from a working Mozilla and
after my manipulation it even worked out. (Datei - Bearbeiten - .....)

After adding a line to initialize the variable I received the
same message and a successful installation as after my first try:

[...]
     [55/55]	Sprache registrieren:
jar:resource:/chrome/de-unix.jar!/locale/de-AT/communicator-platform/
     ** performInstall() returned: 999 (REBOOT_NEEDED)
     ** Line: 0	can't convert Error to string
     ** Line: 413	messages has no properties

     Install **FAILED** with error -229  --  2004-10-03 18:58:34

I should mention that no dialog box is being displayed
(globel/local install.) during Installation.

Comment 5

[Robert Kaiser]

OK, in that case, I think I'll  wrap all blocks the want to put out messages with a
if (messages) { }
block.

This way, the messages just won't be shown if they're somehow not supported
(though I'd love to know why this mechanism works in tier-1 platforms but
seemingly doesn't on OS/2).

A nice side effect is that the XPI package should work without modification in
installer builds in the future.

Comment 6

[Robert Kaiser]

Attachment: try at a new version of the 1.7.3 de-AT install.js

While you're at it, could you try packing the file I just attached here as
install.js of the 1.7.3 package?

If I'm right, it should work correctly. And if it does, I'll pack it into any
future releases that I get out :)

Comment 7

[Marcus Staender]

Works as expected! No messages and no errors. Will you test this on other
platforms yourself?

BTW: Why is an EOF (Dec.26) character at the end of a Javascript not allowed? I
can't remember any information on this. CRs and LFs are accepted.

Comment 8

[Robert Kaiser]

I will test this script on Linux and Windows when I release the next version,
but as messages is defined on tier-1 platforms, it should work as before there.

wrt your other question: I don't know... but you probably can ask some hackers
on on IRC :)

Comment 9

[Robert Kaiser]

FIXED in XPI Nightly Pack 2004-10-20-05