262739 - Save All fails if message name contains unicode

Status: RESOLVED WORKSFORME

(MailNews Core :: Attachments, defect)

Description

[Ivan Ičin]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040913 Firefox/0.10.1
Build Identifier: version 0.8 (20040913)

If I save the message with multiple attachments with 'save all' and one of the
attachments has Unicode letters in filename (tested with Serbian letters: čćšđ)
TB brings message that it cannot save that attachment (it saves other
attachments normally).

Reproducible: Always
Steps to Reproduce:
1. Create message with several attachments and take care that at least one of
them has mentioned non-English unicode letters in filename
2. open message
3. chose from context menu of attachment 'save all'

Actual Results:  
Message that attachment could not be saved

Expected Results:  
Save attachments normally

The message I tested this case was created by clicking several messages,
forwarding them as attachment and then saving new message as draft. It might be
of some influence that attachments were actually mail files.

Comment 1

[Mike Cowperthwaite]

The attachments from bug 234681 show this problem.

You will get one error message for each file which has a Unicode name, but the 
other attachments will be saved.

Note that if you try to save them individually and do not change the suggested 
name, the filename used will have underscore '_' in place of each Unicode 
character.

Comment 2

[klonos]

bug 234681 is fixed in latest 3.0b1pre builds, but only if you save attached files one-by-one. So please keep this bug open...

... On a second test using the second attachment with several unicode-filenamed
attachments [https://bugzilla.mozilla.org/attachment.cgi?id=141675], and while
trying to confirm bug 262739, I noticed the following two things (same 3.0b1pre build as above):

- When saving attachments one-by-one everything is ok, but when you choose
'Save all', the unicode letters are indeed replaced by '_'. This causes an
error message in the case you have attachments with the same number of unicode
letters saying that the file already exists and asking if you want to replace
or not.

- This replacing of unicode letters with '_' occurs only for the Chinese,
Japanese and Hebrew filenames. For the Spanish, the 'español.txt' is saved as
'espanol.txt'.

Comment 5

[Simon Montagu :smontagu]

This WFM on all platforms in 3.0b3