262750 - some missing tooltips on the Help toolbar buttons

Status: RESOLVED FIXED

(SeaMonkey :: Help Viewer, defect)

Description

[Steffen Wilberg]

The sidebar, home, and zoom buttons have no tooltips.

Comment 1

[Steffen Wilberg]

Attachment: patch

We already have the strings, so let's use them!

Just the find button has no tooltip string, but that's hidden by default
anyway.

Comment 2

[Steffen Wilberg]

Attachment: untabbify

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 160961 [details] [diff] [review]
untabbify

>Index: mozilla/toolkit/components/help/content/help.xul
>===================================================================
>RCS file: /cvsroot/mozilla/toolkit/components/help/content/help.xul,v
>retrieving revision 1.1.4.1.2.11
>diff -u -r1.1.4.1.2.11 help.xul
>--- mozilla/toolkit/components/help/content/help.xul	27 Sep 2004 07:07:46 -0000	1.1.4.1.2.11
>+++ mozilla/toolkit/components/help/content/help.xul	4 Oct 2004 01:37:29 -0000
>@@ -148,9 +148,10 @@
>             <toolbarpalette id="HelpToolbarPalette">
> 
>                 <toolbarbutton id="help-sidebar-button"
>-                	class="toolbarbutton-1"
>-                	customizeable="true" label="&sidebarBtn.label;"
>-                	command="Help:ToggleSidebar"/>
>+                    class="toolbarbutton-1"
>+                    customizeable="true" label="&sidebarBtn.label;"
>+                    tooltiptext="&sidebarBtn.tooltip;"
>+                    command="Help:ToggleSidebar"/>
>                 <toolbarbutton id="help-back-button" type="menu-button"
>                         class="browserButton" label="&backButton.label;"
>                         oncommand="if (event.target==this) goBack(); else 

just add the line with the same indenting.  You don't need/want to pick up cvs
blame if you're changing the indenting to be wrong anyway.  ;)

not to harp on it or anything, but the indentation style in the help viewer is
totally wrong by Mozilla standards, and if it wasn't for the "I don't want to
own blame for all of Help" factor I'd probably just change it all myself.

Now, if we're rewriting big chunks of code, it might make sense to adapt to a
much more standardized code formatting to fit with the rest of /toolkit, on a
file-by-file basis.

Comment 4

[Jeff Walden (gone starting June 8)]

Comment on attachment 160961 [details] [diff] [review]
untabbify

Asking for approval-aviary...

So Mike, what's the spacing style?

In toolkit/content/charsetOverlay.xul:
-four spaces per nested element

In toolkit/content/commonDialog.xul:
-two spaces per nested element
-attributes aligned with the one attribute placed on the same line as the
element name
  -if few attributes, all on same line as element

Also:
-indent extra DTDs two spaces?

It appears charsetOverlay.xul is anomalous, but I'd like to be certain.  When
we know what the style is, spacing is easily corrected and sounds like a good
idea for something to do for Help docs and Help viewer code (After Firefox
1.0).

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 160961 [details] [diff] [review]
untabbify

a=asa for aviary checkin.

Comment 6

[Steffen Wilberg]

Checked in br & trunk, with the same indentation.

Comment 7

[Steffen Wilberg]

Just fixed a typo on branch and trunk: The tooltiptext of the
"help-zoom-large-button" is textZoomEnlargeBtn.tooltip, not
textZoomReduceBtn.tooltip.