live bookmarks leak memory/RDF resources

RESOLVED FIXED

Status

()

Firefox
Bookmarks & History
RESOLVED FIXED
13 years ago
12 years ago

People

(Reporter: vlad, Assigned: vlad)

Tracking

({fixed-aviary1.0, mlk})

1.0 Branch
x86
All
fixed-aviary1.0, mlk
Points:
---
Bug Flags:
blocking-aviary1.0 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [eta 10/11])

Attachments

(1 attachment)

6.10 KB, patch
Ben Goodger (use ben at mozilla dot org for email)
: review+
shaver
: superreview+
Ben Goodger (use ben at mozilla dot org for email)
: approval-aviary+
Details | Diff | Splinter Review
I just realized today that on every live bookmark reload, we end up "leaking"
the resources that were in use for the previous set of items.  Right now, we
just remove the items from the parent container.  Since internally everything
gets stored in an InMemoryDataSource, the old triples (rdf:$anon -> Name -> ...,
etc.) are still in the data source, they're just not in any bookmark container.

The fix is to grope all outbound arcs from each rdf:$anon item, and unassert
each one.  Patch soon.
Status: NEW → ASSIGNED
Flags: blocking-aviary1.0+

Comment 1

13 years ago
Needs mlk keyword.
Whiteboard: [eta 10/11]

Updated

13 years ago
Keywords: mlk
Created attachment 161801 [details] [diff] [review]
262758-livemark-refresh-leaks-memory-0.patch

This patch clears out all the arcs whenever we remove a bookmark item; note
that looking at this, we have the same kinds of leaks whenever a user removes a
normal bookmark -- the resources and literals still stick around in the rdf
datasource, until the user quits and restarts.	This isn't as big of a deal,
because deleting bookmarks isn't that common of an operation, but it should be
fixed at some point.

This also seems to have the nice side effect of making the "Open in tabs" menu
item less broken with live bookmarks; if the menu is open when the load
finishes, the items appear, but "Open in tabs" doesn't appear -- it appears the
next time the menu is selected.  We don't, however, get the separator and other
 stuff appearing in weird places, etc.
Attachment #161801 - Flags: superreview?(shaver)
Attachment #161801 - Flags: review?(bugs)
Attachment #161801 - Flags: superreview?(shaver) → superreview+
Comment on attachment 161801 [details] [diff] [review]
262758-livemark-refresh-leaks-memory-0.patch

r+a=ben@mozilla.org
Attachment #161801 - Flags: review?(bugs)
Attachment #161801 - Flags: review+
Attachment #161801 - Flags: approval-aviary+
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Keywords: mlk → fixed-aviary1.0
Resolution: --- → FIXED

Updated

13 years ago
Keywords: mlk
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → bookmarks
You need to log in before you can comment on or make changes to this bug.