Closed Bug 26286 Opened 25 years ago Closed 24 years ago

Hook up advanced editor dialog for "All Tags" editing mode

Categories

(Core :: DOM: Editor, defect, P1)

Product:
Core
Component:
DOM: Editor
Platform:
x86
Windows 95
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: rubydoo123, Assigned: cmanske)

References

Details

(Whiteboard: [nsbeta2+ until 5/16] Composer feature work) 

Hook up advanced editor dialog for unknown tags
Target Milestone: M16
Status: NEW → ASSIGNED
We will be showing an icon for all known HTML tags as well as "unknown" tags
in an editing mode labels "Show All Tags" (button on toolbar at bottom of 
content window.) We wanted double Clicking on these icons should bring up 
Advanced Edit dialog, but that may be too difficult to implement. We could
probably add a "Edit Properties" item to the context popup menu  (rt mouse
click on Windows/Linux).
This depends on getting "unknown" tags working.
Depends on: 22262
Summary: Hook up advanced editor dialog for unknown tags → Hook up advanced editor dialog for "All Tags" editing mode
updating keyword and status whiteboard to reflect that this is a beta 2 feature 
work bug that the Composer team deems a must fix for beta 2.
Severity: normal → major
Keywords: beta2
Priority: P3 → P1
Whiteboard: Composer feature work
Keywords: nsbeta2
This is essentially the same task as 34519. The issue is how to detect when
the icons used in "All tags mode" is selected. The dependency on this problem
might make it slip m16, but completing 34519 will mean there's nothing really
more to do once selection works.
Depends on: 34519
Keywords: beta2
Unfortunately, when we use the taller images, it revealed a problem.
The image size is 16px wide by 35px high.
This example works for block tags: 
p { 
  min-height: 35px; margin-left: 2px; margin-top: 2px; 
  padding-left: 18px; 
  background: url(chrome://editor/skin/images/tag-p.gif) no-repeat; 
  background-position: top left; 
} 

This doesn't work for inline: 
b { 
  min-height: 35px; margin-left: 2px; margin-top: 2px; 
  padding-left: 18px; 
  background: url(chrome://editor/skin/images/tag-b.gif) no-repeat; 
  background-position: top left; 
} 

This works for inline: 
u:before { 
  min-height: 35px; margin-left: 2px; 
  content: url(chrome://editor/skin/images/tag-u.gif); 
} 

But we would prefer to use the "background" rule, as it will be very difficult
to get consistent behavior for selecting the icon and bringing up the 
properties dialog. I've already asked Mike Judge to make a single click on
"before" generated content image select the generated content (we need that
for the single odd case of named anchor, which has no "normal" content.)
Using "before" rule for the All Tags mode would conflict with that behavior.
We already decided that trapping double-click on the "background" icon is the
way we want to implement the "All Tags" mode.
Marc: Why doesn't setting the min-height for an inline tag work? Is that a bug?

[nsbeta2+ until 5/16]
Whiteboard: Composer feature work → [nsbeta2+ until 5/16] Composer feature work
Double click on any tag icon in 'Show All Tags' mode brings up Advanced Edit
dialog. Note that performance is slow, so it may take awhile for the dialog
to appear - be patient!
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
verified in 5/11 build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.