262885 - In <commandglue.js>, "Warning: redeclaration of var i" and "Warning: assignment to undeclared variable node"

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a4) Gecko/20040927] (release) (W98SE)

{{
Warning: redeclaration of var i
Source File: chrome://messenger/content/commandglue.js
Line: 1124, Column: 13
Source Code:
    for (var i = 0; i < termsArray.Count(); i++)
}}

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1-MAS) <commandglue.js> [Checked in: Comment 4]

Comment 2

[Stefan Borggraefe]

Why the strange indentation? :-(

Comment 3

[Serge Gautherie (:sgautherie)]

(In reply to comment #2)
> Why the strange indentation? :-(

Moving toward "2 characters" (not 4) indentation...

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 161078 [details] [diff] [review]
(Av1-MAS) <commandglue.js> [Checked in: Comment 4]


Check in: { 2004-10-04 20:26	bienvenu%nventure.com	mozilla/ mailnews/
base/ resources/ content/ commandglue.js     1.243 }

Comment 5

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1-TB) <commandglue.js>

Comment 6

[Stefan Borggraefe]

(In reply to comment #3)
> (In reply to comment #2)
> > Why the strange indentation? :-(
> 
> Moving toward "2 characters" (not 4) indentation...

I don't think this should be done this way. You only make things worse, because
now there is inconsistent indentation even inside the span of a single function.

IMHO one should either reindent the whole function or just leave the identation
as it is (probably better in this case, because you only need to change a few
lines to fix this bug and reindenting the whole rest would make cvs blame less
useful).

Comment 7

[Serge Gautherie (:sgautherie)]

Another warning:
{{
Warning: assignment to undeclared variable node
Source File: chrome://messenger/content/commandglue.js
Line: 742
}}

Comment 8

[Serge Gautherie (:sgautherie)]

Attachment: (Cv1-MAS) <commandglue.js> [Checked in: Comment 14]

Comment 9

[Serge Gautherie (:sgautherie)]

David:
Could we have this one r&sr and checked in for v1.8a5 ?

Comment 10

[[e-mail]]

Comment on attachment 161657 [details] [diff] [review]
(Cv1-MAS) <commandglue.js>
[Checked in: Comment 14]

My fault :-[ Sorry for letting this slip in.

Comment 11

[Asa Dotzler [:asa]]

Serge, we are never going to block a release because of a js warning. Please
only use the blocking nomination flag if you genuinely believe that the problem
is severe enough to block the shipping of that particular release.

Comment 12

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b) Gecko/20050212] (nightly) (W98SE)

(New line number:)
{{
Warning: assignment to undeclared variable node
Source File: chrome://messenger/content/commandglue.js
Line: 761
}}

Comment 13

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 161657 [details] [diff] [review]
(Cv1-MAS) <commandglue.js>
[Checked in: Comment 14]

a=caillon for 1.8b

Comment 14

[Serge Gautherie (:sgautherie)]

Comment on attachment 161657 [details] [diff] [review]
(Cv1-MAS) <commandglue.js>
[Checked in: Comment 14]


Check in: { 2005-02-14 16:13	neil%parkwaycc.co.uk	mozilla/ mailnews/
base/ resources/ content/ commandglue.js     1.254 }

Comment 15

[Serge Gautherie (:sgautherie)]

Comment on attachment 161207 [details] [diff] [review]
(Bv1-TB) <commandglue.js>

[Mozilla Thunderbird, version 1.0.1 (20050309)] (nightly) (W98SE)

No super-review from <[e-mail]> since "2004-10-05" :-(

Could you (super-)review/check in this patch ? Thanks.

Comment 16

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1a-TB) <commandglue.js>

Bv1, plus a nit fix.

[Mozilla Thunderbird, version 1.0+ (20050319)] (nightly) (W98SE)

Could you review/check in this patch ? Thanks.

Comment 17

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1b-TB) <commandglue.js> [Checkin: Comment 18]

Bv1a-TB, plus (forgotten) Cv1-MAS port.

[Mozilla Thunderbird, version 1.0+ (20050319)] (nightly) (W98SE)

Could you review/check in this patch ? Thanks.

Comment 18

[Serge Gautherie (:sgautherie)]

Comment on attachment 177964 [details] [diff] [review]
(Bv1b-TB) <commandglue.js>
[Checkin: Comment 18]


Checkin: {
2007-04-27 05:33	bugzilla%standard8.demon.co.uk 	mozilla/mail/base/content/commandglue.js 	1.76
}