Closed Bug 262892 Opened 20 years ago Closed 17 years ago

In <mail3PaneWindowCommands.js>, "Warning: redeclaration of var parentResource"

Categories

(SeaMonkey :: MailNews: Message Display, defect)

Product:
SeaMonkey
Component:
MailNews: Message Display
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.8alpha6

People

(Reporter: sgautherie, Assigned: sgautherie)

Details

Attachments

(1 file, 1 obsolete file)

(Bv1-TB) <mail3PaneWindowCommands.js> [Checkin: Comment 9]
1.78 KB, patch
bryner
: review+
mscott
: superreview+
Details | Diff | Splinter Review 
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a4) Gecko/20040927] (release) (W98SE)

{{
Warning: redeclaration of var parentResource
Source File: chrome://messenger/content/mail3PaneWindowCommands.js
Line: 950, Column: 20
Source Code:
                var parentResource =
selectedFolder.parent.QueryInterface(Components.interfaces.nsIRDFResource);
}}
Assignee: sspitzer → gautheri
Status: NEW → ASSIGNED

    
  

        Attachment #161082 -
        Flags: superreview?(bienvenu)

        Attachment #161082 -
        Flags: review?(bienvenu)

    
  

        Attachment #161082 -
        Flags: superreview?(bienvenu)

        Attachment #161082 -
        Flags: superreview+

        Attachment #161082 -
        Flags: review?(bienvenu)

        Attachment #161082 -
        Flags: review+

    
  
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 161082 [details] [diff] [review]
(Av1-MAS) <mail3PaneWindowCommands.js> [Checked in: Comment 2]


Check in: { 2004-10-04 21:07	bienvenu%nventure.com	mozilla/ mailnews/
base/ resources/ content/ mail3PaneWindowCommands.js	     1.138 }

        Attachment #161082 -
        Attachment description: (Av1) <mail3PaneWindowCommands.js> (SeaMonkey part) → (Av1) <mail3PaneWindowCommands.js> (SeaMonkey part)
[Checked in: Comment 2]

        Attachment #161082 -
        Attachment is obsolete: true

    
  
Target Milestone: --- → mozilla1.8alpha5

    
  

        Attachment #161209 -
        Flags: superreview?(bienvenu)

        Attachment #161209 -
        Flags: review?(bienvenu)
Product: Browser → Seamonkey

    
    

    
  
Re-opening, for the Toolkit part, which missed "Mozilla v1.8a5".
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
  
Status: REOPENED → ASSIGNED

    
  
Target Milestone: mozilla1.8alpha5 → mozilla1.8alpha6

    
    

    
  
Comment on attachment 161209 [details] [diff] [review]
(Bv1-TB) <mail3PaneWindowCommands.js>
[Checkin: Comment 9]

No (super-)review from <bienvenu@nventure.com> since "		2004-10-05" :-(

        Attachment #161209 -
        Attachment description: (Bv1) <mail3PaneWindowCommands.js> (Toolkit part) → (Bv1-TB) <mail3PaneWindowCommands.js>

        Attachment #161209 -
        Flags: superreview?(mscott)

        Attachment #161209 -
        Flags: superreview?(bienvenu)

        Attachment #161209 -
        Flags: review?(bryner)

        Attachment #161209 -
        Flags: review?(bienvenu)

        Attachment #161209 -
        Flags: review?(bryner) → review+

    
  

        Attachment #161082 -
        Attachment description: (Av1) <mail3PaneWindowCommands.js> (SeaMonkey part)
[Checked in: Comment 2] → (Av1-MAS) <mail3PaneWindowCommands.js> [Checked in: Comment 2]

    
    

    
  
I'm only going to approve this if you can tell me it has been tested :)

    
    

    
  
(In reply to comment #6)
> I'm only going to approve this if you can tell me it has been tested :)

All right...

What I did test is it's MAS counterpart which was checked in 5 months ago.

Brian, could you test and state it ?

(I would still be happy if someone could give me a name of a "true" FF+TB
developper/tester to help me/us on these simple patches...)

    
    

    
  
Comment on attachment 161209 [details] [diff] [review]
(Bv1-TB) <mail3PaneWindowCommands.js>
[Checkin: Comment 9]

[Mozilla Thunderbird, version 1.0.1 (20050309)] (nightly) (W98SE)

Scott, it fixes the warning ! ...

    
  

        Attachment #161209 -
        Flags: superreview?(mscott) → superreview+

    
    

    
  
Comment on attachment 161209 [details] [diff] [review]
(Bv1-TB) <mail3PaneWindowCommands.js>
[Checkin: Comment 9]


Checkin: {
2007-04-27 05:29	bugzilla%standard8.demon.co.uk 	mozilla/mail/base/content/mail3PaneWindowCommands.js 	1.38
}

        Attachment #161209 -
        Attachment description: (Bv1-TB) <mail3PaneWindowCommands.js> → (Bv1-TB) <mail3PaneWindowCommands.js>
[Checkin: Comment 9]

    
  
Status: ASSIGNED → RESOLVED
Closed: 20 years ago → 17 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: