262898 - [FIX]hotmail.com - large gap between buttons and from/subject header titles

Status: RESOLVED FIXED

(Core :: Layout: Positioned, defect, P1)

Description

[Ian Neal]

In both buildID 2004100206 and 2004100406 on WinXP SP1 there is now a large gap
(about 8-10cm) between the new/delete/block etc buttons and the
from/subject/date, etc header column titles.
It was working fine in BuildID 2004093006
Steps to reproduce
1. Start Mozilla
2. Go to above URL
3. Log into hotmail account
4. Select My Messages or Mail links

Expected results
1. No large gap

Actual results
1. Large gap

Comment 1

[Ian Neal]

Attachment: Screenshot showing problem

Comment 2

[Ian Neal]

Also happens in BuildID 2004100106

Comment 3

[Ian Neal]

Attachment: Reduced testcase

I'm guessing it is the CSS style VISIBILITY:hidden that is causing the problem.

Comment 4

[Ian Neal]

cc'ing bz as he checked in css stuff in the regression window.

Comment 5

[Boris Zbarsky [:bzbarsky]]

> I'm guessing it is the CSS style VISIBILITY:hidden that is causing the problem.

It's not (it shouldn't affect layout, and doesn't; you can check this pretty
easily by removing it).

I'll see how much more I can reduce the testcase here... thank you for reducing
it to something manageable to start with!

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: Really reduced testcase

Comment 7

[Boris Zbarsky [:bzbarsky]]

Yeah, this is mine. It's a regression from bug 191151.  Thanks for catching
this, Ian!

Comment 8

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 161106 [details] [diff] [review]
Patch

Short story: constructFrameByDisplayType had the code to set
isAbsolutelyPositioned and isFixedPositioned in all three of the positioned
branches (positioned block with overflow:not-visible, positioned block with
overflow:visible, and table).  The patch in bug 191151 removed the last of
these... which broke positioning of tables.

This patch just hoists the set up to the toplevel of the function and removes
it from the other two branches too.

Comment 10

[Boris Zbarsky [:bzbarsky]]

Fixed.