r:\mozilla\layout\html\document\src\nsframeframe.cpp(632) : warning C4715: 'ConvertOverflow' : not all control paths return a value

RESOLVED FIXED in mozilla1.8beta3

Status

()

--
trivial
RESOLVED FIXED
14 years ago
13 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

Trunk
mozilla1.8beta3
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 obsolete attachments)

(Assignee)

Description

14 years ago
r:\mozilla\layout\html\document\src\nsframeframe.cpp(632) : warning C4715:
'ConvertOverflow' : not all control paths return a value

perhaps a default case w/ ns_error?
(Assignee)

Comment 1

13 years ago
Created attachment 187544 [details] [diff] [review]
proposal
Assignee: dbaron → timeless
Status: UNCONFIRMED → ASSIGNED
Attachment #187544 - Flags: superreview?(dbaron)
Attachment #187544 - Flags: review?(dbaron)
How about putting it outside the switch?
(Assignee)

Comment 3

13 years ago
Created attachment 187602 [details] [diff] [review]
is this what you mean?
Attachment #187602 - Flags: superreview?(dbaron)
Attachment #187602 - Flags: review?(dbaron)
Attachment #187544 - Flags: superreview?(dbaron)
Attachment #187544 - Flags: superreview-
Attachment #187544 - Flags: review?(dbaron)
Attachment #187544 - Flags: review-
Attachment #187602 - Flags: superreview?(dbaron)
Attachment #187602 - Flags: superreview+
Attachment #187602 - Flags: review?(dbaron)
Attachment #187602 - Flags: review+
(Assignee)

Updated

13 years ago
Attachment #187602 - Flags: approval1.8b3?

Comment 4

13 years ago
Comment on attachment 187602 [details] [diff] [review]
is this what you mean?

a=bsmedberg for checkin on 6/30 only
Attachment #187602 - Flags: approval1.8b3? → approval1.8b3+
(Assignee)

Updated

13 years ago
Attachment #187544 - Attachment is obsolete: true
(Assignee)

Comment 5

13 years ago
Comment on attachment 187602 [details] [diff] [review]
is this what you mean?

mozilla/layout/generic/nsFrameFrame.cpp 	3.285
Attachment #187602 - Attachment is obsolete: true
(Assignee)

Updated

13 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.8beta3
Blocks: 287540
You need to log in before you can comment on or make changes to this bug.