263132 - IME reconverting does not work with IME of Japanese

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a5) Gecko/20041004
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a5) Gecko/20041004

IME reconverting does not work with "Japanist".

It works before 20040820xx build.
I think that this is regression of Bug 238773.

Reproducible: Always
Steps to Reproduce:
1. Input string.
2. Commit the String.
3. Select the commited string.
4. Reconvert the selected string.

Actual Results:  
It doesn't work.

Expected Results:  
The selected string should be composition string.

Comment 1

[Ilya Konstantinov]

Jungshik, I'd appreciate if you could confirm this, as I don't have Windows nor
have IME software installed on Linux (but I'll be glad to hear what apps I need
to get to take care of those bugs).

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I can reproduce with "ATOK" and "MS-IME".

Comment 3

[Jungshik Shin]

Nakano-san fixed several IME-related bugs and his confirmation should be
sufficient to get this confirmed. 

As for testing on Linux, I'll check whether this issue is relevant on Linux and
let you know what you can do to reproduce it on Linux (if it's not just a
windows issue but an XP issue). 

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I don't know to reproduce on Linux.
Because I don't know to be able to reconvert the string on Linux.
However, I think that the reconvert code is XP code.
See http://lxr.mozilla.org/seamonkey/source/widget/src/windows/nsWindow.cpp#6409

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

This bug cannot be reproduced on Linux.
Because Linux doesn't support to reconvert.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

Comment 7

[Ilya Konstantinov]

Comment on attachment 164756 [details] [diff] [review]
Patch

Oops. Looks like I indeed forgot it. Good catch, masayuki.

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Jungshik:

Would you check-in the patch?

Comment 9

[Jungshik Shin]

checked into trunk

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Thank you, Jungshik.