263151 - Turn on libpng MMX optimizations

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Bernard Alleysson]

libpng has support for MMX but it is not currently enabled in Mozilla browsers.

Comment 1

[Bernard Alleysson]

Attachment: enable MMX

I don't know the status of libpng MMX code, but I guess that this bug has to be
filed. I'm running with it with no problem so far. It should speed up png
decoding in some cases.

Comment 2

[Bernard Alleysson]

tor, let me know if you think it is worth considering.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Is this something worth considering still? Also, is the patch above incomplete? From what I can tell, it also needs the following #defines to be enabled, no?

#define PNG_ASSEMBLER_CODE_SUPPORTED
#define PNG_MMX_CODE_SUPPORTED
#define PNG_HAVE_MMX_READ_FILTER_ROW
#define PNG_HAVE_MMX_READ_INTERLACE
#define PNG_HAVE_MMX_COMBINE_ROW
#define PNG_USE_PNGVCRD

Comment 4

[Michael Moy]

This patch has been used in unofficial builds for quite some time with no problems that I'm aware of. The performance improvement is about 25% in my png image suite.  

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 161259 [details] [diff] [review]
enable MMX

According to the comments in pngconf.h, this patch is actually obsolete anyway.
http://mxr.mozilla.org/mozilla/source/modules/libimg/png/pngconf.h#725

Comment 6

[Glenn Randers-Pehrson]

Yes, this bug was fixed by checkin of bug #334110 if not earlier.