263180 - Threaded mail view in Virtual Folders is not possible

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, enhancement)

Description

[Volkmar W. Pogatzki]

All sorting options "Threaded" "Unthreaded" "Grouped by Sort" are greyed out for
Virtual Folders. 
Selecting the sort order by klicking the column heads in the message pane works
for other columns but not for the Thread column.

Tested with:
http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/2004-10-06-06-0.8/thunderbird-i686-linux-gtk2+xft.tar.gz

Comment 1

[David :Bienvenu]

that's right, virtual folders, like quick searches and search results, which
they're based on, can't be threaded currently. I hope to be able to implement
that someday but it will be after 1.0 - the new grouping threading code makes it
at least possible.

Comment 2

[Mike Cowperthwaite]

(In reply to comment #1)
> that's right, virtual folders, like quick searches and search results, which
> they're based on, can't be threaded currently.

Mailview/Quicksearch threading is Seamonkey bug 135326, and TB bug 265625.

Comment 3

[blujay]

Please!  It seems really silly to suddenly not be able to group messages just
because you clicked the drop-down "View" box and selected something other than
"All".  It's so useful, but to not be able to do it except in "View: All"
is...really disappointing.  :(

Comment 4

[Svetoslav Milenov]

Yes, this will be a useful feature. As far as there is no way to make a filter
to apply on outgoing mail, there is no other way to get the conversations with a
specific person in one place, and group them by thread.

Comment 5

[David :Bienvenu]

*** Bug 295467 has been marked as a duplicate of this bug. ***

Comment 6

[Jim Meyer]

Please add another "me, too," to this one. I'm switching from Evolution, where I
integrate two incoming mail stores with a number of virtual folders. I don't
suppose there's any guess on when this one will be delivered, is there?

Thanks!

--j

Comment 7

[David :Bienvenu]

we're aiming for tbird 2.0

Comment 8

[David :Bienvenu]

Attachment: thread quick search results and single folder virtual folders

this allows us to thread quick search results and virtual folders with a single
folder scope (but not virtual folders that search over multiple folders). That
last case will require a lot of work, but I thought handling the first two
cases was worthwhile right now, since it's not too difficult.

Comment 9

[Mike Cowperthwaite]

(In reply to comment #8)
> Created an attachment (id=197367) [edit]
> thread quick search results and single folder virtual folders

MailViews too?

Comment 10

[David :Bienvenu]

yes, mail views too.

Comment 11

[David :Bienvenu]

*** Bug 135326 has been marked as a duplicate of this bug. ***

Comment 12

[David :Bienvenu]

this fix is incomplete - I'm not handling the case of a new matching message
arriving in the folder when the view is threaded. It currently adds the message
to the end of the view. I'll fix that and attach a new patch.

Comment 13

[David :Bienvenu]

Comment on attachment 197367 [details] [diff] [review]
thread quick search results and single folder virtual folders

clearing request.

Comment 14

[David :Bienvenu]

Attachment: fix adding new hdr when threaded

one line change from last patch :-)

Comment 15

[Mike Cowperthwaite]

*** Bug 265625 has been marked as a duplicate of this bug. ***

Comment 16

[Olli Männistö]

Very nice, when can I grab a nightly with the patch? And which nightly? 

Comment 17

[David :Bienvenu]

Attachment: patch I'll be checking in.

this is the same as the previous patch, except that it now remembers if a
single folder virtual folder was threaded the last time you opened the folder,
and if you're threaded when you do a quick search, the results are threaded.
The last might be surprising at first because it's a change, but I think it's
what threaded users will want. It'll certainly make threading of quick search
results discoverable!

Comment 18

[David :Bienvenu]

fixed on trunk.

Comment 19

[David :Bienvenu]

Attachment: sort by threads if we go into quick search in a VF while threaded

this makes it so we retain the threadedness when going into and out of a quick
search while in a threaded VF.

Comment 20

[David :Bienvenu]

Attachment: don't thread quick search results if we're grouped

we were going into threaded mode when doing a quick search in a grouped view...

Comment 21

[Scott MacGregor]

Comment on attachment 198598 [details] [diff] [review]
patch I'll be checking in.

it's time for this one too. 

Has no effect on Firefox.

Comment 22

[u69748]

I see duplicated thread in thread view in virtual folder.

+ message1
  + message1-1
  + message1-2
+ message1
  + message1-1
  + message1-2

Is there any bug?

Comment 23

[u69748]

I filed Bug 312598

Comment 24

[Mike Cowperthwaite]

*** Bug 279126 has been marked as a duplicate of this bug. ***

Comment 25

[Eliot Blennerhassett]

This bug is marked as resolved/fixed yet threading does not work for virtual folders that contain results from more than one real folder (comment #8).
Unless this is covered by another bug, I'd say this bug is not fully resolved yet.

(Don't ge me wrong, I think the threading of single source searches is a great improvement, but it doesn't cover how I use them E.g all the mail to/from somebody...)

Comment 26

[Mike Cowperthwaite]

(In reply to comment #25)
> This bug is marked as resolved/fixed yet threading does not work for virtual
> folders that contain results from more than one real folder (comment #8).
> Unless this is covered by another bug, I'd say this bug is not fully resolved
> yet.

Bug 267727 comment 11 mentions that grouping is not working, and that the menu options for Thread/Group are disabled when such a folder is selected.

Comment 27

[uridavid.akavia]

I don't know if this should be a new bug or if it is a part of this bug. I use TB1.5 - with this version threading is possible, but greyed out.
If I want to thread, I must select View->Threads->All, and only then can I select threaded view.
In addition, the folder does not remember threading preferences - if I switch to another folder and back, the view is UNthreaded again.

Are both these issues known and resolved? Should this bug be reopened? Should I file other bugs?

Comment 28

[Scott MacGregor]

David, do any of these two follow up patches from 10-12 need put on the 1.8.1 branch? The original patch is in thunderbird 1.5

Comment 29

[David :Bienvenu]

no, they're both in 1.8.1 already, which I think means that they're also in 1.5