263192 - More DTD errors in Thunderbird

Status: VERIFIED FIXED

(Thunderbird :: General, defect)

Description

[Scott MacGregor]

In todays 10/06 bits, I get a DTD error about closeCmd.label not being defined
in the main mail 3:pane window. The xul error box shows up at the bottom of the
window.

Comment 1

[Scott MacGregor]

adding the usual keyword fun...

Comment 2

[Scott MacGregor]

actually you don't even need a release or packaged build to see this.

This error is also visible in a regular debug build without any packaging FUD.

FYI....

Comment 3

[Benjamin Smedberg]

Attachment: preprocess communicator-platform/locale/contents.rdf

Comment 4

[Benjamin Smedberg]

Fixed on branch

Comment 5

[Scott MacGregor]

hmmm that didn't seem to fix it for me. I rebuilt mail\locales with that latest
change and now I get two errors:

1) the same close error because it can't find platformCommunicatorOverlay.dtd

and now a new one:

2) can't find releaseURL; for the throbber...

re-opening

Comment 6

[Benjamin Smedberg]

I just checked in another patch, there was a preexisting issue where
mail/base/jar.mn shipped several files into toolkit.jar that should have gone
into comm.jar (utilityOverlay.xul) which was the cause of the releaseURL entity
error. This problem was masked by the repackaging system, which put these files
"back" into the right place, I believe.

Comment 7

[Scott MacGregor]

(In reply to comment #6)
> This problem was masked by the repackaging system, which put these files
> "back" into the right place, I believe.

That's really weird. I saw both of these problems in a debug build that doesn't
do any repackaging at all. The repackaging only happens for release builds. I'll
test out the fix.

Comment 8

[Scott MacGregor]

benjamin, that fixed the missing exit/close DTD error but the  releaseURL; error
is still there.

File/Edit and View menus are still broken without any DTD entries in the headers.

Again this requires no packaging to see this. Just a debug build will show it to
you. So it's not related to the release packaging scripts at all.

Comment 9

[Benjamin Smedberg]

-* locale/navigator-platform/contents.rdf (generic/chrome/navigator-region/contents.rdf)
+* locale/navigator-platform/contents.rdf (generic/chrome/navigator-platform/contents.rdf)

Damn, I apologize for doubting your error, this didn't show up in my build
because chrome.rdf had it cached... I was installing the wrong contents.rdf,
which was messing up both global-platform and navigator-platform :(

In my local build, I'm still missing the text from View -> Toolbars, it's more
like View -> "" -> (the toolbar list)... is this string loaded from a properties
file or something like that?

Comment 10

[Scott MacGregor]

your latest fix seems to have done the trick!

I'm geting View / Toolbars text as well. (it should be going from a DTD file)

Comment 11

[Scott MacGregor]

*** Bug 263236 has been marked as a duplicate of this bug. ***

Comment 12

[Scott MacGregor]

Hmmm my debug build at home is still having the error about the label for close
not being found. I just did a fresh clobber build and i still see it.

I think the problem is that the auto generated installed-chrome.txt in
dist\bin\chrome is registering:

locale,install,url,jar:resource:/chrome/en-win.jar!/locale/en-US/navigator-platform/
locale,install,url,jar:resource:/chrome/en-win.jar!/locale/en-US/communicator-platform/
locale,install,url,jar:resource:/chrome/en-win.jar!/locale/en-US/global-platform/

but there is no more en-win.jar file getting generated by the build anymore.

Comment 13

[Marcia Knous [:marcia]]

Scott: Using today's build on the Mac (version 0.8 (20041007)) I am still seeing
issues that are likely related to the DTD errors.  This was also reported in the
forums: http://forums.mozillazine.org/viewtopic.php?t=141101.

I am unable to reply to an email using the Mac. I am also seeing the <menuitem
id="menu_close" label="&closeCmd.label;"............../> error that Talios
reported in the forum.

Sarah hasn't seen this on Linux, and I downloaded today's windows build and I
don't have trouble replying to mail and I don't see the errors on the screen
that I see on the mac.

Comment 14

[Gordon Griswold]

Attachment: This is how The Mac version 0.8 (20041007) of TB appears after launch

The 20041006 Mac version of TB is clean!

Comment 15

[Benjamin Smedberg]

OK, the random incorrect lines in installed-chrome.txt were from "libs" targets in
xpfe/global/Makefile.in
xpfe/communicator/Makefile.in
xpfe/browser/Makefile.in

which I wasn't picking up using "make chrome". This has been fixed. I also
reverted mail/base/jar.mn since it was causing the View -> Toolbars menuitem to
be blank. It appears that the mail/ versions of these three files are bogus and
should be removed.

If there are more errors, could we open a new bug? This one has morphed twice,
although I know that is hard to notice because most of the DTD errors look the
same on the outside.

Comment 16

[sairuh (rarely reading bugmail)]

haven't seen these problems for a while, so vrfy'ing. if others like this crop
up, pls file a separate bug rather than reopening this. thanks!

Comment 17

[Markus Stange [:mstange] (back Aug 27)]

Attachment: MozReview Request: Bug 263192 - Clip scrolled contents to the display port. r?mattwoodrow

Review commit: https://reviewboard.mozilla.org/r/52335/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52335/

Comment 18

[Robert Longson [:longsonr]]

Have you attached this patch to the wrong bug Markus?

Comment 19

[Robert Longson [:longsonr]]

wrong bug Markus?

Comment 20

[Markus Stange [:mstange] (back Aug 27)]

oops, thank you, sorry about that.