263238 - Error about addCurPageCmd.commandkey entity with 1.8a4 on OS/2

Status: VERIFIED FIXED

(Mozilla Localizations :: de / German, defect)

Description

[Peter Weilbacher]

Mozilla/5.0 (OS/2; U; Warp 4.5; de-AT; rv:1.8a4) Gecko/20040930

After installing the German language pack from
<http://mozilla.kairo.at/download.php?ver=1.8a4#LangPack> on Mozilla 1.8apha4 on
OS/2 and activating it, I get this message in the lower part of the window:

    <key id="addBookmarkKb" key="&addCurPageCmd.commandkey;"
command="Browser:AddBookmark" modifiers="accel,shift"/>
---------------------------------^

Normally, I would assume that the entity &addCurPageCmd.commandkey; is missing
from the language pack, but in this case that is not it. This only happens with
the de-AT pack, not e.g. zh-TW. No tricks with cleaning the profile etc. work.

Hmm, after searching a bit more, I can make this error go away if I add a line
<!ENTITY addCurPageCmd.commandkey "z">
to locale\de-AT\navigator-platform\platformNavigationBindings.dtd that is packed
into de-unix.jar. But I still don't understand why, as this entity is present
neither in en-unix.jar nor zh-unix.jar and English and Chinese both work without
the error. I cannot find anything in Bugzilla about this and no messages in the
other newsgroups, so I guess this is OS/2 only.

Comment 1

[Mike Kaply [:mkaply]]

It sounds like their platform checking code is incorrect.

They are making OS/2 a unix variant when it should be a win variant.

So my guess is that we have code that follows the win path expexcting an xx-win
variant, and the key isn't there.

This makes that clear:

http://lxr.mozilla.org/seamonkey/search?string=addCurPageCmd.commandkey

we use the windows version of platformNavigationBindings.xul so we have to use
the windows version of platformNavigationBindings.dtd.

Can you post their install.js file?

I fixed this bug many ages ago here:

http://lxr.mozilla.org/seamonkey/source/xpinstall/packager/common/share.t#68

People should be using this version of getPlatform.

Comment 2

[Peter Weilbacher]

Yes, the OS/2 case is missing in the install.js of the de-AT language pack while
it is present in the zh-TW XPI. This would be the patch

--- install.js	Sat Oct  2 21:19:16 2004
+++ install_withOS2.js	Thu Oct  7 12:32:01 2004
@@ -232,6 +232,8 @@
       platformNode = 'mac';
     else if (!platformStr.search(/^Win/))
       platformNode = 'win';
+    else if (!platformStr.search(/^OS\/2/))
+      platformNode = 'win';
     else
       platformNode = 'unix';
   }

I will try tonight on OS/2 if it works.

Comment 3

[Mike Kaply [:mkaply]]

Did you get this solved?

Comment 4

[Peter Weilbacher]

Yes, the patch from comment 2 works fine here. Is there a file in the Seamonkey
tree that I should create a patch against, or do we need to wait for KaiRo do
update it in the LanguagePack?

Comment 5

[Mike Kaply [:mkaply]]

The tree has the right files - will have to wait for kairo to update the langpack

Comment 6

[Mike Kaply [:mkaply]]

Can we get rid of this one yet?

Comment 7

[Michael Stadlbauer]

FIXED in Nightly XPI pack 2004-11-19-05 as I see. I think Robert forgot to close
the bug.

Comment 8

[Robert Kaiser]

I actually didn't forget it but wanted to wait for 1.8a5 before closing it, so
someone with OS/2 can verify it more easily...

Comment 9

[Peter Weilbacher]

Verified fixed with 1.8a5 and corresponding mozilla-1.8a5.de-AT.langpack.xpi
LanguagePack.