263250 - base href for simple buglists

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

The simple buglist format was designed to be embedded into other pages via
iframes, f.e. in the Bugzilla helper, but it references a stylesheet using a
relative URL (css/buglist.css).  It should include a base tag so the stylesheet
URL can be resolved when the page is loaded within an iframe of a page loaded on
another site.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: adds base tag to head section of simple buglists

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 161323 [details] [diff] [review]
patch v1: adds base tag to head section of simple buglists

Gerv, got time to review this one-line fix?

Comment 3

[Gervase Markham [:gerv]]

Comment on attachment 161323 [details] [diff] [review]
patch v1: adds base tag to head section of simple buglists

r=gerv.

Gerv

Comment 4

[Vlad Dascalu]

Comment on attachment 161323 [details] [diff] [review]
patch v1: adds base tag to head section of simple buglists

If the maintainer hasn't visited editparams.cgi yet, then this patch actually
makes it impossible to view the CSS (before applying the patch, the CSS would
be viewable for iframes on the same host as the BZ install)

Comment 5

[Myk Melez [:myk] [@mykmelez]]

> If the maintainer hasn't visited editparams.cgi yet, then this patch actually
> makes it impossible to view the CSS

That's true of all parts of Bugzilla that use the urlbase parameter, like
bugmail, dependency graphs, and reports, and more reason for installers to set
their urlbase appropriately.  Perhaps we should prompt them for it in
checksetup.pl to make that more automatic.

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Thanks Gerv.

Checking in list-simple.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/list-simple.html.tmpl,v
 <--  list-simple.html.tmpl
new revision: 1.9; previous revision: 1.8
done

Checking in ../bz218/template/en/default/list/list-simple.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/list-simple.html.tmpl,v
 <--  list-simple.html.tmpl
new revision: 1.7.2.1; previous revision: 1.7
done