263255 - Improve thread pane UI for message grouping

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Scott MacGregor]

Tracking bug for some CSS improvements I hope to make to build off of David's
great grouping feature.

Comment 1

[Scott MacGregor]

Attachment: some possible ideas

Here are a couple of different looks...

Comment 2

[Scott MacGregor]

Attachment: another idea

Comment 3

[Scott MacGregor]

Attachment: patch for some UI improvements for grouping

Comment 4

[David :Bienvenu]

Comment on attachment 161385 [details] [diff] [review]
patch for some UI improvements for grouping

I'm a little torn about removing the thread column, since it could be used to
switch to normal threaded mode, if it worked, but it does look cleaner without
it...

Comment 5

[Scott MacGregor]

Other things I'd like to try to address here:

1) Adding a customizeable toolbar button for popping you in and out of grouped
mode, making this feature more visible.

2) I need to do some mac osx theme work to make this work for Mac

3) For messages from yesterday, maybe just showing the time instead of a date
stamp on the msg.

4) double clicking a dummy group row causes us to open the next msg in a stand
alone window....

Comment 6

[Scott MacGregor]

Attachment: some CSS to get grouping going on Mac OS X

Kevin will probably want to style this in a nice OS X friendly fashion but this
gets us going.

Comment 7

[Scott MacGregor]

Comment on attachment 162136 [details] [diff] [review]
some CSS to get grouping going on Mac OS X

wrong patch

Comment 8

[Scott MacGregor]

Attachment: OS X CSS rules for grouping

Comment 9

[Scott MacGregor]

the OS X style rules have been checked into the branch and the trunk but they
could use some more OS X specific polish.

Comment 10

[Scott MacGregor]

Attachment: patch to get rid of column re-ordering, make all attributes group with dummy rows except for subject

Comment 11

[Scott MacGregor]

Comment on attachment 162668 [details] [diff] [review]
patch to get rid of column re-ordering, make all attributes group with dummy rows except for subject

David, what do you think of this patch?

1) No more column re-ordering

2) as we discussed all sort attributes except for the subject now use dummy
rows

3) Some of our sort attributes like priority, lable and status have states with
no title text so I had to make up some entries such as "No Status" or "No
Priority" to show up in the UI for that particular container.

4) I'd like to get rid of the code that shows/hides the thread icon next but am
still mulling that over. 

I'm sure I broke something in here when toggling back and forth between group
by sorted, threaded mode, etc. with my threadpane.js changes :)

Comment 12

[David :Bienvenu]

Comment on attachment 162668 [details] [diff] [review]
patch to get rid of column re-ordering, make all attributes group with dummy rows except for subject

looks good, thx, Scott!

Comment 13

[Scott MacGregor]

Attachment: screen shot showing grouping for things like labels and date

screen shot to show off how grouping now looks when you are sorted by
attributes like Label and Date.

Subject is now the only one that won't use these dummy rows.

Comment 14

[Scott MacGregor]

I think we've gotten enough mileage out of this bug. Further improvements can be
handled in separate bugs.

Closing this out. All of the patches are in the branch and trunk. 

Comment 15

[Peter Lairo]

Minor nit: The "mark as deleted" icon (envelope with red X) doesn't appear in
grouped view.

Comment 16

[Scott MacGregor]

Hmm that worked for me Peter using todays build. I went into grouped mode by
date. Deleted a message and saw the red X next to the icon. Are you using the
default theme? I"m sure most themes haven't been updated to work right with
groups yet. 

Comment 17

[Peter Lairo]

(In reply to comment #16)
version 0.8 (20041021), winXP, default theme (plus "purge" button extension <-
should be in default theme, BTW), IMAP, setting: mark as deleted, sort by date,
send e-mail to self, select message, press g, re-select message, click delete
button -> message's envelope icon is *not* marked with red X.

Comment 18

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #17)
> version 0.8 (20041021), winXP, default theme (plus "purge" button extension <-
> should be in default theme, BTW), IMAP, setting: mark as deleted, sort by date,
> send e-mail to self, select message, press g, re-select message, click delete
> button -> message's envelope icon is *not* marked with red X.

I repeated your steps with version 1.0 (20041206) and all behaves well. Peter
can you test again with a recent version? Perhaps this could be fixed by the
theme update before 1.0.

Comment 19

[Peter Lairo]

(In reply to comment #18)
> Peter can you test again with a recent version? 

OK, it works now - Thunderbird "version 1.0 (20041212)"

BTW: It would be nice if the selected message *stayed selected* when toggling
between grouped and listed views. (I never use grouped view)