Closed Bug 263276 Opened 20 years ago Closed 20 years ago

copy changes to toolkit/content/customizeToolbar.xul

Categories

(SeaMonkey :: Help Viewer, defect)

Product:
SeaMonkey
Component:
Help Viewer
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: steffen.wilberg, Assigned: jwalden+fxhelp)

Details

(Keywords: fixed-aviary1.0, polish)

Attachments

(1 file)

Patch
1.51 KB, patch
Details | Diff | Splinter Review 
There are now keys defined for ESC, Return, and Enter, all accepting the
Customize Toolbar dialog:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/content/customizeToolbar.xul&rev=&cvsroot=/cvsroot&mark=47-51#47

We need to copy these to toolkit/components/help/content/customizeToolbar.xul.
No l10n impact.
Attached patch Patch — — Splinter Review 

    
    

    
  
Comment on attachment 161547 [details] [diff] [review]
Patch

Dunno if you have time for this, Mike, but as it's just the same patch as the
URL referenced in comment 0, you might be able to make time for it.

        Attachment #161547 -
        Flags: review?(mconnor)

    
    

    
  
sorry, I don't have the time/inclination to do Mozilla stuff for the time being.
 Please find another reviewer.

    
  

        Attachment #161547 -
        Flags: review?(mconnor) → review?(bugs)

    
    

    
  
This is a consistency issue, so customize windows should act the same throughout
the application.  There's also a completely trivial patch with no l10n impact. 
Requesting blocking-aviary1.0 status...
Flags: blocking-aviary1.0?
Keywords: polish
Whiteboard: [have patch][needs review ben]

    
    

    
  
Comment on attachment 161547 [details] [diff] [review]
Patch

Looks good to me Jeff. r=rlk@trfenv.com. Lets get aviary approval and get
things moving. Ben is most likely too busy for review.

        Attachment #161547 -
        Flags: review?(bugs)

        Attachment #161547 -
        Flags: review+

        Attachment #161547 -
        Flags: approval-aviary?

    
  
Whiteboard: [have patch][needs review ben] → [have patch][needs aviary approval]

    
    

    
  
Comment on attachment 161547 [details] [diff] [review]
Patch

a=asa for aviary checkin.

        Attachment #161547 -
        Flags: approval-aviary? → approval-aviary+

    
    

    
  
Fix checked in on branch and trunk.
Status: NEW → RESOLVED
Closed: 20 years ago
Keywords: fixed-aviary1.0
Resolution: --- → FIXED
Whiteboard: [have patch][needs aviary approval]
Target Milestone: --- → Firefox1.0

    
  
Flags: blocking-aviary1.0?

    
  
Flags: review+
Flags: approval-aviary+
Product: Firefox → Toolkit
Target Milestone: Firefox1.0 → ---
Version: 1.0 Branch → unspecified
Product: Toolkit → Seamonkey

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: