26351 - Access violation in nsImageRender.cpp

Status: VERIFIED FIXED

(Core :: Graphics: ImageLib, defect, P3)

Description

[David Gardiner]

I did a clobber build this morning (my time), and am getting an access violation 
as mozilla starts up.
 
Breaking to the VC debugger, it gets to line 228 of gfx\src\nsImageRenderer.cpp. 
For some reason the nsIImage object is null.
 
Here is the relevant method:
 
NS_IMETHODIMP
ImageRendererImpl::SetDecodedRect(   IL_Pixmap* aImage, 
                    PRInt32 x1, PRInt32 y1,
                                PRInt32 x2, PRInt32 y2)
{
  nsIImage         *img = (nsIImage *)aImage->client_data;
 
  img->SetDecodedRect(x1, y1, x2, y2); // Crash occurs here
  return NS_OK;
}

And here is the call stack:
 
ImageRendererImpl::SetDecodedRect(ImageRendererImpl * const 0x02c55c28, 
_NI_Pixmap * 0x02049938, int 46170416, int 0, int 80987, int 46268424) line 228 
+ 19 bytes
il_size(il_container_struct * 0x02c50e10) line 807
ImgDCallbk::ImgDCBImageSize(ImgDCallbk * const 0x02c510d8) line 172 + 12 bytes
il_gif_write(il_container_struct * 0x02c50e10, const unsigned char * 0x02c15078, 
long 98) line 1337 + 18 bytes
GIFDecoder::ImgDWrite(GIFDecoder * const 0x02c5f260, const unsigned char * 
0x02c15078, long 98) line 76 + 20 bytes
IL_StreamWrite(il_container_struct * 0x02c50e10, const unsigned char * 
0x02c15078, long 98) line 1002 + 26 bytes
NetReaderImpl::Write(NetReaderImpl * const 0x02c51288, const unsigned char * 
0x02c15078, long 98) line 100 + 20 bytes
ImageConsumer::OnDataAvailable(ImageConsumer * const 0x02c51350, nsIChannel * 
0x02c51818, nsISupports * 0x00000000, nsIInputStream * 0x02c52750, unsigned int 
0, unsigned int 98) line 365 + 23 bytes
nsDocumentOpenInfo::OnDataAvailable(nsDocumentOpenInfo * const 0x02c512f8, 
nsIChannel * 0x02c51818, nsISupports * 0x00000000, nsIInputStream * 0x02c52750, 
unsigned int 0, unsigned int 98) line 256 + 46 bytes
nsResChannel::OnDataAvailable(nsResChannel * const 0x02c5181c, nsIChannel * 
0x02c51ce0, nsISupports * 0x00000000, nsIInputStream * 0x02c52750, unsigned int 
0, unsigned int 98) line 619
nsFileChannel::OnDataAvailable(nsFileChannel * const 0x02c51ce4, nsIChannel * 
0x02c52088, nsISupports * 0x00000000, nsIInputStream * 0x02c52750, unsigned int 
0, unsigned int 98) line 468 + 49 bytes
nsOnDataAvailableEvent::HandleEvent(nsOnDataAvailableEvent * const 0x02c53358) 
line 370
nsStreamListenerEvent::HandlePLEvent(PLEvent * 0x02c533b0) line 93 + 12 bytes
PL_HandleEvent(PLEvent * 0x02c533b0) line 526 + 10 bytes
PL_ProcessPendingEvents(PLEventQueue * 0x01f9ccb8) line 487 + 9 bytes
_md_EventReceiverProc(HWND__ * 0x00d00254, unsigned int 49839, unsigned int 0, 
long 33148088) line 975 + 9 bytes
USER32! 77e13eb0()
USER32! 77e1401a()
USER32! 77e192da()
nsAppShellService::Run(nsAppShellService * const 0x01f9c6c0) line 456
nsProfile::LoadDefaultProfileDir(nsCString & {...}) line 335 + 32 bytes
nsProfile::StartupWithArgs(nsProfile * const 0x01faef98, nsICmdLineService * 
0x01f9c468) line 225 + 12 bytes
main1(int 1, char * * 0x00ab6948) line 543 + 41 bytes
main(int 1, char * * 0x00ab6948) line 690 + 13 bytes
mainCRTStartup() line 338 + 17 bytes
KERNEL32! 77e98b5b()

I hope bug belongs in ImageLib..
-dave

Comment 1

[pnunn]

Got it.
-pn

Comment 2

[David Gardiner]

Just to say that this morning, my build worked ok, so i don't know if this bug
is that real now.

Comment 3

[pnunn]

Waiting to check in.
-pn

Comment 4

[pnunn]

Checked in... but cvs comment mentions wrong bug#.
_sigh_
-pn

Comment 5

[Eli Goldberg]

Pam, shall I rubber-stamp this as verified, or would you like to designate a peer 
(or yourself) to verify?

Thanks!

Comment 6

[pnunn]

I will testify that I put the code in.
-pn