Closed Bug 263524 Opened 20 years ago Closed 20 years ago

0.10.1 build breaks when using custom DESTDIR

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: bugs, Assigned: bryner)

References

Details

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040914
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040914

Any build with using "make DESTDIR=/tmp/firefox-build-whatever install" will
fail at the profile copying.  Line 319 in mozilla/browser/app/Makefile.in needs
to be changed from (w/context):

install:: $(srcdir)/profile/prefs.js
        $(SYSINSTALL) $(IFLAGS1) $^ $(destdir)$(bindir)/defaults/profile

to:

install:: $(srcdir)/profile/prefs.js
        $(SYSINSTALL) $(IFLAGS1) $^ $(DESTDIR)$(bindir)/defaults/profile


Reproducible: Always
Steps to Reproduce:
Pull from CVS and build!
Actual Results:  
nsinstall complains about trying to install the prefs.js file into /usr/local/bin


Expected Results:  
Installed into $DESTDIR/usr/local/bin


It's a simple patch to fix.
Yep, I confirm that this problem exists. Verify by setting the DESTDIR to 
somewhere that a user has write permissions to, and then do the install as 
non-root. Assuming that the non-root user does not have access to 
$(bindir)/defaults/profile (safe bet), then the install will fail. We have 
come across this problem while building for OpenEmbedded. 
This also happens to me on Solaris with the firefox 1.0 source tar file.
Confirmed but no longer interesting because the Firefox 1.0 branch has been closed.

On the trunk it has been fixed, see bug 255958.

Yep, that's a dup of this bug.  I'll fix the dependency on this bug and close it.
Status: UNCONFIRMED → RESOLVED
Closed: 20 years ago
Depends on: 255958
Resolution: --- → FIXED
Please close it as a DUPLICATE, WORKSFORME or INVALID if there wasn't an actual
fix in this bug.

See https://bugzilla.mozilla.org/bug_status.html .
Status: RESOLVED → UNCONFIRMED
Resolution: FIXED → ---
Bug 263524 is a DUPLICATE from this one.
Ehmm bug 255775 is a duplicate from this one
WFM per comment 3.
Status: UNCONFIRMED → RESOLVED
Closed: 20 years ago → 20 years ago
Resolution: --- → WORKSFORME
*** Bug 255775 has been marked as a duplicate of this bug. ***
Component: Build Config → General
Product: Firefox → Firefox Build System
You need to log in before you can comment on or make changes to this bug.