263530 - "Find in Message" in quicksearch should be disabled unless message is in focus

Status: RESOLVED WORKSFORME

(Thunderbird :: Mail Window Front End, defect)

Description

[sairuh (rarely reading bugmail)]

found using 20041008-0.8 bits on linux fc2 and mac os x 10.3.5. I was confused
as to how the "Find in Message" quicksearch option worked --until Marcia noticed
that it works on a single message. (unlike the quicksearch options, which work
on the entire folder of messages.)

would it be possible to disable (grey out) "Find in Message" in the quicksearch
dropmenu unless a message header (in thread pane) or message body has focus?

Comment 1

[sairuh (rarely reading bugmail)]

on a related noted, should "Save as Virtual Folder" become disabled if "Find in
Message" has been selected? (I don't see why a search based on a single message
should be saved as Virtual Folder, but please let me know if I'm
misunderstanding this feature.)

Comment 2

[sairuh (rarely reading bugmail)]

comment 1 was fixed as part of bug 263552. thanks, scott!

Comment 3

[Tracy Walker [:tracy]]

Find in message behaves like FF Find with highlight on.  In FF, Find searches
the page and highlights whatever is matched.  This is the same thing, but in the
message pane rather than the browser window.  Why should it be disabled if we
don't have a message selected? One example; Select Go | Mail Start Page. No
message is selected, but perhaps you want to search the content of the message pane.

Comment 4

[sairuh (rarely reading bugmail)]

focus needs to be in either the message or thread pane for this feature to work.
so if focus is elsewhere, then the "find in message" menu item should be
appropriately disabled. otherwise it seems confusing when it doesn't "seem" to
be working.

Comment 5

[Cody 'codeman38' Boisclair]

It doesn't help that the wording itself is a bit confusing-- it's tripped me up
several times, anyway.  Perhaps "Find In This Message" would work better, or
something along those lines clarifying that it only refers to the *active* message.

Comment 6

[Armin Fuerst]

Until today I interpreted this option as "Find in Body". I would suggest to
rename this option to "Search current message".
As an alternative, I could imagine creating a second textfield for searches
in the current message as a contrast to searching all messages in the
current folder. It is confusing having the same textfield one time searching the
folder and the other time searching the message.

Comment 7

[Wayne Mery (:wsmwk)]

"Find in This Message" from edit menu item is disabled unless a message is displayed.  version 2.0.0.12 (20080213)
=> WFM