Closed
Bug 263550
Opened 21 years ago
Closed 21 years ago
Respect overflow attribute of svg:svg
Categories
(Core :: SVG, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: tor, Assigned: tor)
Details
Attachments
(1 file, 1 obsolete file)
|
16.75 KB,
patch
|
scootermorris
:
review+
|
Details | Diff | Splinter Review |
Attachment #161531 -
Flags: review?(scootermorris)
Attachment #161531 -
Attachment is obsolete: true
Attachment #161531 -
Flags: review?(scootermorris)
Attachment #163476 -
Flags: review?(scootermorris)
|
||
Comment 3•21 years ago
|
||
Comment on attachment 163476 [details] [diff] [review]
add bulletproofing
>Index: layout/svg/base/src/nsSVGInnerSVGFrame.cpp
>===================================================================
>RCS file: /cvsroot/mozilla/layout/svg/base/src/nsSVGInnerSVGFrame.cpp,v
>retrieving revision 1.2
>diff -u -8 -p -r1.2 nsSVGInnerSVGFrame.cpp
>--- layout/svg/base/src/nsSVGInnerSVGFrame.cpp 13 Sep 2004 22:55:43 -0000 1.2
>+++ layout/svg/base/src/nsSVGInnerSVGFrame.cpp 26 Oct 2004 22:18:53 -0000
......
>+ if (svgElement)
>+ svgElement->GetViewBox(getter_AddRefs(viewBox));
>+ if (viewBox)
>+ viewBox->GetAnimVal(getter_AddRefs(vb));
>+ if (vb) {
>+ float x, y, width, height;
>+ vb->GetX(&x);
>+ vb->GetY(&y);
>+ vb->GetWidth(&width);
>+ vb->GetHeight(&height);
>+ nsCOMPtr<nsIDOMSVGMatrix> ctm = GetCanvasTM();
>+ canvas->SetClipRect(ctm, x, y, width, height);
>+ }
>+ }
>+
>
Alternatively,
if (svgElement) {
svgElement->GetViewBox(getter_AddRefs(viewBox));
if (viewBox) {
viewBox->GetAnimVal(getter_AddRefs(vb));
if (vb) {
float x, y, width, height;
vb->GetX(&x);
vb->GetY(&y);
vb->GetWidth(&width);
vb->GetHeight(&height);
nsCOMPtr<nsIDOMSVGMatrix> ctm = GetCanvasTM();
canvas->SetClipRect(ctm, x, y, width, height);
}
}
}
..
Attachment #163476 -
Flags: review?(scootermorris) → review+
Checked in, using straightline error test rather than nested blocks.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•