263579 - Clearing your search results and save as a Virtual Folder saves the original search results.

Status: RESOLVED DUPLICATE of bug 267377

(Thunderbird :: General, defect)

Description

[trix supremo]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; rv:1.7.3) Gecko/20040914 Firefox/0.10
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.3) Gecko/20040914 Firefox/0.10

If you Clear your search message results, then click the Save as Virtual Folder,
your original search results are listed in the Virtual Folder.

Reproducible: Always
Steps to Reproduce:
1. Send 3 messages to self (ie w/subject: test 1, test 2, test 3.
2. Search for messages (ie: Edit|Find|Search Messages) w/subject "2"
3. With results displayed, click on the Clear button to clear results.
4. Now click on the Save as Virtual Folder button.
5. Open the virtual folder.

Actual Results:  
The search results prior to the Clear are listed.

Expected Results:  
If results are cleared, Tbird should not allow a user to Save as Virtual Folder.

Since the Save as Virtual Folder button was initially disabled when no search
results were listed, it should be disabled once the user uses the Clear button.

Comment 1

[David :Bienvenu]

when you save a virtual folder, you're not saving the search results; you're
saving the search terms, or search criteria. So clearing the results doesn't
mean that saving the search as a virtual folder should be turned off, as long as
clearing the results doesn't reset the search terms back to the default. If that
argument makes sense, can we resolve the bug was invalid or wfm?

Comment 2

[trix supremo]

David:
Whats happening is after a search, when you Clear, you not only remove the
results but your also removing the search criteria (meaning the criteria and
results of the prior search are no longer displayed). After the Clear, the Save
as Virtual Folder button remains enabled and executing this saves the criteria
and results prior to the Clear.

So basically my argument is if you Clear which removes the display of the
criteria and results, why does it make sense to allow a user to save the
criteria of a prior search after the user had just Cleared it?

If this is expected behavior, then i'm ok with resolving this as invalid, but
would like to debate this function at another time because from a user
perspective, this would be introducing an unfamiliar function.  There aren't
many scenarios in other apps which a user has an option to Clear and yet when
saving, the prior criteria or results are being saved.

Comment 3

[David :Bienvenu]

no, you're right - clearing the search also clears the search criteria, in which
case, save as virtual folder should be disabled.  I thought it just cleared the
results...

Comment 4

[Mike Cowperthwaite]

(In reply to comment #3)
> no, you're right - clearing the search also clears the search criteria, in
> which case, save as virtual folder should be disabled.

I am seeing the "Save as virtual folder" item disabled when QS is empty, 
in TB 0.9.
Trix Supremo, do you still see this problem?

Comment 5

[Scott MacGregor]

I fixed this just before 0.9 was released. 

*** This bug has been marked as a duplicate of 267377 ***