263608 - Javascript Debugger Toolbar has no icons in

Status: RESOLVED FIXED

(Other Applications Graveyard :: Venkman JS Debugger, defect)

Description

[Ian Neal]

Using BuildID 2004100805 on WinXP SP2
Steps to reproduce:
1. Select Javascript debugger from Tools, Web Development menu

Expected results:
1. Javascript debugger opens with toolbar full of icons

Actual results:
1. Javascript debugger opens with completely empty toolbar

Comment 1

[Ian Neal]

Regression happens between BuildID 2004100407 and BuildID 2004100506
The following messages appears in the interactive session window as well:
Internal error dispatching command “pprint”.
TypeError: tb has no properties @ <chrome://venkman/content/venkman-commands.js>
1286

Comment 2

[Ian Neal]

This also stops JS debugging work as each time the debugger tries to alter the
state of icon on the toolbar it gives a "tb has no properties" error.
Severity -> Critical

Comment 3

[James Ross]

Woah, the console is not a pretty sight. ASSERTION FAILED left right and center. :)

Comment 4

[James Ross]

Well, that was a hum-dinger of a bug. Patch in a sec.

Comment 5

[James Ross]

Attachment: Get actual string, not an array of 1 item

This was fun. It seems that, until recently, the following code returned true:

    ["foo"] in { foo: 1 }

even though you'd expect it not to (the array isn't a property of the object,
now is it?). This has been fixed, it seems, and the menu code kinda relied on
it, though purely accidentally I think. This patch makes it pass the actual
command name, instead of an array containing the name.

Comment 6

[Robert Ginda]

Comment on attachment 161611 [details] [diff] [review]
Get actual string, not an array of 1 item

r=rginda
Thanks!

Comment 7

[James Ross]

Checked in, should be fixed in the next round of nightly builds.