263653 - [FIX][v1.8a4] A case where ViewSource shows wrong source, while PageIngo is correct. (== uses HTTP instead of cache :-()

Status: VERIFIED FIXED

(Core :: DOM: Navigation, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7.3) Gecko/20040910] (release) (W98SE)

WorksAsExpected.

v1.8a3(release) worked fine too, as I remember.


[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a4) Gecko/20040927] (release) (W98SE)

Reproducible: 100%

Testcase:
too hard to explain: it's a game, and the characters have to be active at the
time of test, ...

What happens:
1. I'm on a frame in a frameset, and I click to select an active character
   (Notice that this calls a javascript function which does a submit on a POST
form.)
2. I get to a "fullscreen" (= no more frameset) page
3. On that page
3a. "View Page Info": URL = <http://www.battle-arenas.net/arenes.php> with
Referer = <http://www.battle-arenas.net/equipe.php>: correct
3b: "View Page source": I get a page with title "Source of:
http://www.battle-arenas.net//index.php?principal=intro": obviously wrong source.

ViewSource seems to work corectly in (all) other cases: works fine for the
frameset and its frames for example.

Ask me if I can provide more (log/cache/...) data !

Comment 1

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a4) Gecko/20040927] (release) (W98SE)

HTTP request to display the page (step 1):
{{
+++GET 2507+++
Using Proxy - curie.noos.net:8080
POST http://www.battle-arenas.net/arenes.php HTTP/1.1
Host: www.battle-arenas.net
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a4) Gecko/20040927
Accept:
text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5
Accept-Language: fr-fr,fr;q=0.8,en-gb;q=0.7,en;q=0.5,es-es;q=0.3,es;q=0.2
Accept-Encoding: gzip,deflate
Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7
Keep-Alive: 300
Referer: http://www.battle-arenas.net/equipe.php
Cookie: Compte=MjQyOTU%3D; Pack=1; TOPIC_BLOCK=20; Pass=QWRHLVQx;
Joueur=TW96aWxsYU1hc3Rlci1UMQ%3D%3D;
Pack_Path=W%3A%5CProgs%5C%40Battle-Arenas%5Cba_pack%5C; MESS_BLOCK=50;
PHPSESSID=dc1d9649d8db92b4c809f7fd3dc8ee67
Content-Type: application/x-www-form-urlencoded
Content-Length: 19
Connection: keep-alive
Posting 19 bytes...
acces_direct=114568

+++RESP 2507+++
HTTP/1.1 200 OK
Date: Sat, 09 Oct 2004 18:23:58 GMT
Content-Length: 9998
Content-Type: text/html
Server: Apache/1.3.31 (Unix) mod_gzip/1.3.19.1a PHP/4.3.8 mod_ssl/2.8.19
OpenSSL/0.9.6m
X-Powered-By: PHP/4.3.8
Set-Cookie: PHPSESSID=dc1d9649d8db92b4c809f7fd3dc8ee67; path=/
Pragma: no-cache
Content-Encoding: gzip
Via: 1.1 curie (NetCache NetApp/5.3.1R2DEBUG12)
+++CLOSE 2507+++
}}

HTTP request to display the source (step 3b):
{{
+++GET 2509+++
Using Proxy - curie.noos.net:8080
POST http://www.battle-arenas.net/arenes.php HTTP/1.1
Host: www.battle-arenas.net
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a4) Gecko/20040927
Accept:
text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5
Accept-Language: fr-fr,fr;q=0.8,en-gb;q=0.7,en;q=0.5,es-es;q=0.3,es;q=0.2
Accept-Encoding: gzip,deflate
Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7
Keep-Alive: 300
Referer: http://www.battle-arenas.net/equipe.php
Content-Type: application/x-www-form-urlencoded
Content-Length: 19
Connection: keep-alive
Posting 19 bytes...
acces_direct=114568

+++RESP 2509+++
HTTP/1.1 302 Found
Transfer-Encoding: chunked
Date: Sat, 09 Oct 2004 18:25:43 GMT
Content-Type: text/html
Server: Apache/1.3.31 (Unix) mod_gzip/1.3.19.1a PHP/4.3.8 mod_ssl/2.8.19
OpenSSL/0.9.6m
X-Powered-By: PHP/4.3.8
Set-Cookie: PHPSESSID=6d4052017f092402980d0ca889af9efd; path=/
Pragma: no-cache
Location: http://www.battle-arenas.net//index.php?principal=intro
Via: 1.1 curie (NetCache NetApp/5.3.1R2DEBUG12)
+++CLOSE 2509+++
}}

I don't know why the response is different :-(

But the fact that there is HTTP traffic reminds me of bug 166786 (which I did
not read in details).

Comment 2

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7.3) Gecko/20040910] (release) (W98SE)

HTTP request to display the page (step 1):
{{
+++GET 2546+++
Using Proxy - curie.noos.net:8080
POST http://www.battle-arenas.net/arenes.php HTTP/1.1
Host: www.battle-arenas.net
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7.3) Gecko/20040910
Accept:
text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5
Accept-Language: fr-fr,fr;q=0.8,en-gb;q=0.7,en;q=0.5,es-es;q=0.3,es;q=0.2
Accept-Encoding: gzip,deflate
Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7
Keep-Alive: 300
Referer: http://www.battle-arenas.net/equipe.php
Cookie: MESS_BLOCK=50; TOPIC_BLOCK=20;
Pack_Path=W%3A%5CProgs%5C%40Battle-Arenas%5Cba_pack%5C; Compte=MjQyOTU%3D;
Pack=1; PHPSESSID=0e4140d6bc146f6a6b77b7ba7868e258
Content-Type: application/x-www-form-urlencoded
Content-Length: 19
Connection: keep-alive
Posting 19 bytes...
acces_direct=114568

+++RESP 2546+++
HTTP/1.1 200 OK
Date: Sat, 09 Oct 2004 18:33:03 GMT
Content-Length: 10082
Content-Type: text/html
Server: Apache/1.3.31 (Unix) mod_gzip/1.3.19.1a PHP/4.3.8 mod_ssl/2.8.19
OpenSSL/0.9.6m
X-Powered-By: PHP/4.3.8
Set-Cookie: PHPSESSID=0e4140d6bc146f6a6b77b7ba7868e258; path=/
Pragma: no-cache
Content-Encoding: gzip
Via: 1.1 curie (NetCache NetApp/5.3.1R2DEBUG12)
+++CLOSE 2546+++
}}

HTTP request to display the source (step 3b):
{{
*** NO HTTP Traffic !! ***
}}

The question becomes:
Why does v1.8a4 use HTTP in this case ??

Comment 3

[Boris Zbarsky [:bzbarsky]]

Serge, can you find exactly when this broke by testing nightly builds between
1.8a3 and 1.8a4?

Comment 4

[Serge Gautherie (:sgautherie)]

(In reply to comment #3)
> Serge, can you find exactly when this broke by testing nightly builds between
> 1.8a3 and 1.8a4?

Too late :-/

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a3) Gecko/20040817] (release) (W98SE)
(Ftp, 1.8a3: 2004.08.17)

I installed it again, and confirms that it works from cache as v1.7.3 does :-)

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a4) Gecko/20040927] (release) (W98SE)
(Ftp, 1.8a4: 2004.09.29)

Trouble is that nightlies only go back as far as 2004-09-29 :-(

Would a HTTP log or something else help instead ?

Comment 5

[Boris Zbarsky [:bzbarsky]]

> Trouble is that nightlies only go back as far as 2004-09-29 :-(

http://archive.mozilla.org/pub/mozilla/nightly/ goes back a lot further than that.

Comment 6

[Serge Gautherie (:sgautherie)]

(In reply to comment #5)
> http://archive.mozilla.org/pub/mozilla/nightly/ goes back a lot further than that.

I didn't know that one :-/

*****

It seems to have regressed between 2004-09-21-06-trunk and 2004-09-22-07-trunk...


Working as expected :-)

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a3) Gecko/20040817] (release) (W98SE)
(Ftp, 1.8a3: 2004.08.17)

2004-09-06-07-trunk
Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a3) Gecko/20040906

2004-09-18-06-trunk
Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a4) Gecko/20040918

2004-09-21-06-trunk
Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a4) Gecko/20040921

Regressed :-(

2004-09-22-07-trunk
Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a4) Gecko/20040922

2004-09-23-07-trunk
Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a4) Gecko/20040923

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a4) Gecko/20040927] (release) (W98SE)
(Ftp, 1.8a4: 2004.09.29)

Comment 7

[Boris Zbarsky [:bzbarsky]]

The only thing in that range that looks related is bug 260314

Comment 8

[Boris Zbarsky [:bzbarsky]]

Attachment: This should fix it

Comment 9

[Darin Fisher]

Comment on attachment 162422 [details] [diff] [review]
This should fix it

r+sr=darin

thanks bz!

Comment 10

[Boris Zbarsky [:bzbarsky]]

Checked in.  Serge, could you verify in tomorrow's builds?

Comment 11

[Serge Gautherie (:sgautherie)]

2004-10-17-07-trunk
Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a5) Gecko/20041017

Buggy.

2004-10-18-07-trunk
Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a5) Gecko/20041018

Fixed :-)