263680 - /FIXED:NO linker option increases executable size

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Brian Ryner (not reading)]

For release builds, we define MOZ_PROFILE (for Seamonkey) or MOZ_DEBUG_SYMBOLS
(for Firefox/Thunderbird, since the static binary is big enough to require pdb
files).  Unfortunately, because of the origin of MOZ_PROFILE (to run with
Quantify), it also passes /FIXED:NO to the linker, which is required for
Quantify to be able to instrument the executable but increases its size by about
6% (firefox static build).

To solve this, we should separate the debug-symbol and quantify options.  I have
a patch which adds an --enable-quantify configure option.  Giving that option
causes /FIXED:NO to be used when linking executables, otherwise it is not used.
 The patch also fixes an oversight, MOZ_DEBUG_SYMBOLS should be added to
autoconf.mk so that it only need to be defined while running configure.

(It would be great to autoconf the MOZ_PROFILE/MOZ_DEBUG_SYMBOLS stuff as well,
i.e. --enable-debug-symbols=[builtin|pdb] but I don't have time for that at the
moment).

Comment 1

[Brian Ryner (not reading)]

Attachment: patch

Comment 2

[Brian Ryner (not reading)]

Comment on attachment 161621 [details] [diff] [review]
patch

Also, I should note that this was uncovered by switching from the MOZ_PDB hack
on the aviary branch to MOZ_DEBUG_SYMBOLS and thus starting to share the linker
options from MOZ_PROFILE.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

+# of executables, so only use it if buliding for Quantify.

nit: typo at "buliding"

Comment 4

[Brian Ryner (not reading)]

Comment on attachment 161621 [details] [diff] [review]
patch

requesting branch approval

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 161621 [details] [diff] [review]
patch

a=asa for aviary and 1.7 checkin.

Comment 6

[Brian Ryner (not reading)]

checked in - trunk, aviary, 1.7.