263733 - Crashes when "Grouped By Sort" is selected and sort criteria is changed to "Order recieved"

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Volkmar W. Pogatzki]

Thunderbird crashes when "Grouped By Sort" is selected AND sort criteria is
changed from "Sender" to "Order recieved".

Bug 263385 already fixed some similar crash.

To reproduce:
1. Create a clean profile with one pop account using "Global Inbox".
2. Recieve some 100 mails.
3. Have "View, Sort by" set to "Sender", "Ascending" and "Grouped By Sort".
4. Select sort criteria from "Sender" to "Order recieved".

Tested with:
http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/2004-10-10-05-0.8/thunderbird-i686-linux-gtk2+xft.tar.gz

Comment 1

[David :Bienvenu]

I can't reproduce this with my debug build...

Comment 2

[Volkmar W. Pogatzki]

Attachment: Testcase, tar.gz including "Inbox.msf" and "Inbox" file

(In reply to comment #1)
> I can't reproduce this with my debug build...

I once repeated this test (new installation, new profile) and got the same
reproducible results (crash). 
Maybe the reproducibility is more dependant on the testing conditions. I'm
including an attachment (tar.gz) containing the "Inbox.msf" and "Inbox" files
of my crashing Inbox. 
As I'm not having access to your debug build (or do I have?) I can only do
tests using the regular nightly builds. Is there some difference between our
builds?

Comment 3

[David :Bienvenu]

Attachment: fix for a couple crashes

this fixes a couple potential crashes (though I don't know if it fixes the one
you're seeing...) it fixes a crash when sorted by recipient and grouped, and
adds some bullet-proofing checks.

Comment 4

[David :Bienvenu]

can you try tomorrow's build? It might be fixed - I wish I could reproduce the
problem so I could be sure, but I couldn't, even with your test case...

the regular nightly builds should be very similar to my own builds.

Comment 5

[Jay Patel [:jay]]

I was able to reproduce this using the original steps with: version 0.8 (20041011)
However, we don't have symbols for the latest branch builds, so the stack isn't
very useful.  When we get symbols up, I will crash again and post my Talkback
incident.

Comment 6

[Volkmar W. Pogatzki]

Attachment: It seems to be fixed

(In reply to comment #4)
> can you try tomorrow's build? It might be fixed 

Yes, it looks better. Doesn't crash any more but "Grouped By Sort" is still
selected.

Comment 7

[David :Bienvenu]

I see the problem - you've all been using the menu item to sort, not the column
header, and that indeed is broken.

Comment 8

[Volkmar W. Pogatzki]

(In reply to comment #7)
> I see the problem - you've all been using the menu item to sort, not the column
> header, and that indeed is broken.

How could one select "Grouped By Sort" or "Threaded" from the column header or,
how could one reach the column headers from the keyboard?

Comment 9

[David :Bienvenu]

clicking on a column header (e.g., date) when grouped by sort undoes the
grouping, and does a flat sort by that column. That's how I was trying to
reproduce this problem. Now that I know you've been using the menu (or the
keyboard), I can see what's wrong with the code.

Comment 10

[David :Bienvenu]

Attachment: proposed fix

this fixes the menu item sort commands to turn off grouping, like clicking on
the column header does.

Comment 11

[David :Bienvenu]

Attachment: better fix

previous fix introduced some regressions in how we go back into threaded mode,
among other things...

Comment 12

[David :Bienvenu]

Comment on attachment 162238 [details] [diff] [review]
better fix

it also broke the pref that makes clicking on a thread pane column not do a
flat sort...

Comment 13

[sairuh (rarely reading bugmail)]

vrfy'd fixed with 200411220x-0.9 on the three main platforms. no more crashing!